1905125 - Enable media.navigator.video.disable_h264_baseline in 128 and future betas

Status: VERIFIED FIXED

(Core :: WebRTC, task)

Description

[Jim Mathies [:jimm]]

[Tracking Requested - why for this release]:
We were working on trying to get snapchat working (Bug 1900114) and shipped a feature there that addressed one of the issues with snapchat. That fix didn't get snapchat working though, there are other things that need to happen for that.

The fix we shipped ended up breaking video streaming on ring.com (bug 1898579). Since snap was always broken, and ring wasn't, and since we don't have a simple way to address the ring.com issue, we'd like to flip 'media.navigator.video.disable_h264_baseline' to false and uplift that to beta 128.

Comment 1

[Dan Baker[:dbaker]]

Attachment: Bug 1905125 - Disabling signaling of H264 Baseline outside of Nightly. r=#webrtc-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bd1388ae6bb
Disabling signaling of H264 Baseline outside of Nightly. r=webrtc-reviewers,ng

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/9bd1388ae6bb

Comment 4

[Donal Meehan [:dmeehan]]

:dbaker could you please add an uplift request on this?
The Fx128 beta cycle is over since the last beta builds today, but we could take this before Fx128 goes to RC.

Comment 5

[Dan Baker[:dbaker]]

Comment on attachment 9410010 [details]
Bug 1905125 - Disabling signaling of H264 Baseline outside of Nightly. r=#webrtc-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Users of Ring.com will not be able to use the live view option see bug 1898579.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This reverts behavior in non Nightly builds to previous number of video codecs being signaled. While there is a test case issue with bug 1905348 that will be resolved separately the failure is only a discrepancy in codecs (8 will be seen in Nightly while other builds will see the original 6).
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9410010 [details]
Bug 1905125 - Disabling signaling of H264 Baseline outside of Nightly. r=#webrtc-reviewers

Approved for 128.0rc1.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/70ad85b37666

Comment 8

[Peter Magyari (Desktop QA)]

Hi,
I have verified the following on MacOS 14, Windows 10 and Ubuntu 24.04:

• media.navigator.video.disable_h264_baseline is true on Firefox 128.0-build 1 (20240701154223)
• media.navigator.video.disable_h264_baseline is false on Nightly 129.0a1 (20240701214557)