1905184 - The reader view menus should not close so easily when scrolling while hovering them

Status: VERIFIED FIXED

(Toolkit :: Reader Mode, defect, P3)

Description

[Daniel Bodea [:danibodea]]

Attachment: Reader view menus close too easily when scrolling over them.webm

Note

• When the user loads a webpage in reader view, opens the Text and layout menu and scrolls when the cursor is displayed over the menu, he will notice that the menu closes.
• Our suggestion for improvement would be to avoid closing the menu when the cursor hovers the menus.

Found in

• Nightly v129.0a1

Affected versions

• Nightly v129.0a1

Tested platforms

• Affected platforms: all
• Unaffected platforms: none

Steps to reproduce

1. Load an article that is compatible with reader view:
   https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal
2. Enable reader view
3. Access the Text and layout menu
4. Hover the cursor over the opened menu.
5. Attempt to scroll the menu.

Expected result

• The menu should not close when the user attempts to scroll while hovering them.
• The menu should only close when the user scrolls while hovering the content area (not the menu).
  OR
• Furthermore, these menus could behave like the Pocket or Account menus from the toolbar: The menu remains opened even if the user scrolls the article. It only closes when the user clicks the content area or it's entry point.

Actual result

• The menu scrolls if there is a scrollbar present; If the position is at the end of the scrollbar, then the menu closes and the article is scrolled instead.
• If there is no scrollbar displayed, then the menu closes instantly and the article is scrolled instead.

Regression range

• Not a regression. A similar behavior is seen in the design before this implementation.

Additional notes

Comment 1

[Daniel Bodea [:danibodea]]

We've decided to modify this report type from an enhancement to a defect considering that the new implementation can show a longer panel and even display a scrollbar. The situation that the panel might close unexpectedly is quite annoying.

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Hey Irene - is this something we might be able to have you look at?

Comment 3

[Irene Ni [:ini]]

Currently we have logic that implements this behaviour here, where once a scroll event is detected, _closeDropdowns(true) is called. A simple fix would be to remove this logic entirely. This would result in the same behavior as the Pocket or Account menus, where the menus remain open on scroll and only close when the user clicks the content area or menu entry point.

Gijs, I'm wondering if you remember the reasoning behind having the menus close on scroll. Now that the text and layout menu is larger and itself scrollable, would it make more sense to have it stay open?

Comment 4

[:Gijs (he/him)]

The logic is from bug 1257953 but I don't remember why we built it that way. And the review context got lost with mozreview. I checked in with Eitan, who hypothesized that it's to do with obstructing text. It looks like the current design still has a situation where the panel is somewhat in front of text, so I don't think keeping the panels open for all scrolls is the right solution.

I think probably what we'll need to do is make sure that using the scrollwheel inside the panel itself doesn't close the panel - is that feasible?

Comment 5

[Irene Ni [:ini]]

Attachment: Bug 1905184 - The reader view menus should not close so easily when scrolling while hovering them. r=#reader-mode-reviewers

Comment 6

[Irene Ni [:ini]]

That makes sense! I've submitted a patch that prevents the menu from closing on scroll if your mouse is within the dropdown window.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b908faa5acb
The reader view menus should not close so easily when scrolling while hovering them. r=reader-mode-reviewers,Gijs

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4b908faa5acb

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 10

[Gabi Cheta [:Gabi] Desktop QA]

Reproduced the issue in Firefox Nightly 129.0a1.
Verified as fixed across platforms in Nightly 132.0a1 and Firefox 131.0b2.