190521 - bug_email.pl attachment might not be named

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[John Williams]

User-Agent:       Mozilla/4.76 [en] (X11; U; Linux 2.4.2-2 i686)
Build Identifier: 

When a bug is created via bug_email.pl, and it has attachments, if the
Content-Description header is blank, the attachment will have no description.
This is mildly annoying because you cannot click on the name of the attachment
to look at it (since there is no name).

Reproducible: Always

Steps to Reproduce:
1. Bugzilla must be configured to use bug_email.pl
2. send an email to bugzilla with an attachment (the Content-Description: header
on the attachment should be missing or blank).

Actual Results:  
The attachment created on the bug will have no name.

Expected Results:  
Bugzilla should use the filename or assign a default name.

Comment 1

[John Williams]

Attachment: recommended_filename patch

This patch fixes the problem.

If the Content-Description header is blank,
it uses MIME::Head::recommended_filename to get a default name.
If that fails, it uses the default of "unnamed attachment".

Comment 2

[Dave Miller [:justdave]]

-> patch author

Comment 3

[Jacob Steenhagen]

Comment on attachment 112546 [details] [diff] [review]
recommended_filename patch

Assuming that you've tested this and head->recommended_filename has always been
in MIME::Parser (as we say in the docs that any version is OK) and taking into
consideration that this is in contrib/, this seems simple enough that I'll
rubber-stamp it.

Comment 4

[Jacob Steenhagen]

Checking in bug_email.pl;
/cvsroot/mozilla/webtools/bugzilla/contrib/bug_email.pl,v  <--  bug_email.pl
new revision: 1.15; previous revision: 1.14
done