1905214 - "Read Aloud" in reader activates on reopening last closed window with keyboard shortcut

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect, P3)

Description

[waiwai95]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:127.0) Gecko/20100101 Firefox/127.0

Steps to reproduce:

On macOS:

1. Open a page which supports Reader mode (e.g. https://en.wikisource.org/wiki/The_Case_Book_of_Sherlock_Holmes_(1927)/The_Adventure_of_the_Mazarin_Stone)
2. Open Reader mode
3. Hit Cmd-Shift-N, the keyboard shortcut to open the last closed window

Actual results:

In addition to the last closed window opening as expected, Read Aloud is activated, presumably because its keyboard shortcut is N.

Expected results:

Read Aloud mode should not have been activated when using a keyboard shortcut.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Reader Mode' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Right - I guess a simple solution here would be to update this event listener to ignore the n character if any modifiers (like Shift or the meta key) are pressed.

Comment 3

[Robert Holdsworth]

Attachment: Bug 1905214 - Read Aloud in reader activates on reopening last closed window with keyboard shortcut r=mconley

Comment 4

[Robert Holdsworth]

Attachment: Bug 1905214 - Read Aloud in reader activates on reopening last closed window with keyboard shortcut. Fixed lint r=mconley

Comment 5

[Robert Holdsworth]

Attachment: Bug 1905214 - Read Aloud in reader activates on reopening last closed window with keyboard shortcut r=mconley

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd7cdf26f310
Read Aloud in reader activates on reopening last closed window with keyboard shortcut r=mconley

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/cd7cdf26f310