1905216 - Move backupSettings.ftl out of preview into the locales folder

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

We should only do this once we're happy with the strings, and the Fluent team is happy with the string IDs and documentation.

Comment 1

[Stephen Thompson [:sthompson]]

Based on target release of Firefox 145, recommend that we do this after 144 -> 145 merge day (Sept 15) and before 145 string freeze (Oct 10), preferably as soon as we have strings in a good place.

Comment 2

[Stephen Thompson [:sthompson]]

Attachment: Bug 1905216 - promote profile backup strings out of preview r=#backup-reviewers

Comment 3

[Bryan Olsson [:bolsson]]

This is a large number of strings, I'd like to communicate with localizers in advance how to test the strings in Nightly/Beta. Are there preferences that they will need to flip or any instructions to follow to review the feature?

Comment 4

[Stephen Thompson [:sthompson]]

Here is a brief description based on my previous experience with this feature.

The pref browser.backup.preferences.ui.enabled must be enabled in order to go to the Sync section of the settings menu (about:preferences#sync) and see the profile backup settings. There is a "Manage backup" button to open a modal to let you choose a backup directory, optionally choose whether to backup sensitive data, and ultimately turn on automatic backups. When this feature is on, it will collect data from your active Firefox profile and pack it into an HTML file. Once the backup HTML file has been created, you can choose to "Show in folder" and open the backup HTML file in any web browser. The backup HTML file contents/strings will be different if you view it in 1) Firefox, or 2) any non-Firefox browser. In about:preferences#sync you can also choose to restore data from a backup HTML file by clicking "Restore...". This opens a modal that lets you pick an HTML file and restore from it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/374197b09958
https://hg.mozilla.org/integration/autoland/rev/2ecd770d91b1
promote profile backup strings out of preview r=fluent-reviewers,bolsson,omc-reviewers,emcminn

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/460dd991693e
https://hg.mozilla.org/integration/autoland/rev/99d1c3c3e309
Revert "Bug 1905216 - promote profile backup strings out of preview r=fluent-reviewers,bolsson,omc-reviewers,emcminn" for causing failures at browser_password_validation_inputs.js.

Comment 7

[Atila Butkovits]

Backed out for causing failures at browser_password_validation_inputs.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/99d1c3c3e3095c2c32a656d0b67a0b31820b41d7

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2ecd770d91b1063be12f6a1797f94cc3b087ee2c&selectedTaskRun=UzaHG8-kTQG73xsVQzshPw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=530834764&repo=autoland&task=UzaHG8-kTQG73xsVQzshPw.0&lineNumber=3625

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1db8be28fcb0
https://hg.mozilla.org/integration/autoland/rev/94e6f1202864
promote profile backup strings out of preview r=fluent-reviewers,bolsson,omc-reviewers,emcminn

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3982a719be59
https://hg.mozilla.org/integration/autoland/rev/a161a59ee2c7
Revert "Bug 1905216 - promote profile backup strings out of preview r=fluent-reviewers,bolsson,omc-reviewers,emcminn" for causing failures at test_password_validation_inputs.html.

Comment 10

[Atila Butkovits]

Backed out for causing failures at test_password_validation_inputs.html.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/a161a59ee2c7cda6f52c3d8f1f214fb25bd6b097

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=94e6f120286483558fb092fc20eca5d057dce1e6&selectedTaskRun=f2v8To9lQ8OET-xEHMFbTA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=530870355&repo=autoland&task=f2v8To9lQ8OET-xEHMFbTA.0&lineNumber=2151

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/74b69afbf45d
https://hg.mozilla.org/integration/autoland/rev/56acb7f05f67
promote profile backup strings out of preview r=fluent-reviewers,bolsson,omc-reviewers,emcminn

Comment 12

[amarc]

https://hg.mozilla.org/mozilla-central/rev/56acb7f05f67