1905253 - Startup crash in [@ mozilla::AppWindow::MoveResize]

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[BugBot [:suhaib / :marco]]

Crash report: https://crash-stats.mozilla.org/report/index/74b99984-9ce9-4604-a952-c6b840240621

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0  xul.dll  mozilla::AppWindow::MoveResize  xpfe/appshell/AppWindow.cpp:677
1  xul.dll  mozilla::AppWindow::SetSize  xpfe/appshell/AppWindow.cpp:618
1  xul.dll  mozilla::AppWindow::SetSpecifiedSize  xpfe/appshell/AppWindow.cpp:1307
2  xul.dll  mozilla::AppWindow::SizeShell  xpfe/appshell/AppWindow.cpp:2501
3  xul.dll  mozilla::AppWindow::OnChromeLoaded  xpfe/appshell/AppWindow.cpp:1088
3  xul.dll  mozilla::AppWindow::OnStateChange  xpfe/appshell/AppWindow.cpp:3064
4  xul.dll  nsDocLoader::DoFireOnStateChange  uriloader/base/nsDocLoader.cpp:1356
5  xul.dll  nsDocLoader::doStopDocumentLoad  uriloader/base/nsDocLoader.cpp:973
6  xul.dll  nsDocLoader::DocLoaderIsEmpty  uriloader/base/nsDocLoader.cpp:784
7  xul.dll  nsDocLoader::OnStopRequest  uriloader/base/nsDocLoader.cpp:667

By querying Nightly crashes reported within the last 2 months, here are some insights about the signature:

• First crash report: 2024-05-02
• Process type: Multiple distinct types
• Is startup crash: Yes - 6 out of 7 crashes happened during startup
• Has user comments: No
• Is null crash: Yes - 6 out of 7 crashes happened on null or near null memory address

Comment 1

[Dan Mehic]

I'm unsure if this belongs to Layout component. If not, help with figuring out the appropriate one is much appreciated. :)

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:jwatt, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1905253 - Add a null-check in AppWindow::MoveResize. r=smaug

Much like the method we forward to.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21edc465b7ce
Add a null-check in AppWindow::MoveResize. r=smaug

Comment 5

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/21edc465b7ce

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9412803 [details]
Bug 1905253 - Add a null-check in AppWindow::MoveResize. r=smaug

Beta/Release Uplift Approval Request

• User impact if declined: rare startup crash
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Null-check
• String changes made/needed: none
• Is Android affected?: Unknown

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9412803 [details]
Bug 1905253 - Add a null-check in AppWindow::MoveResize. r=smaug

Approved for 129.0b6

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2d25a7b26dcd

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Release approval.

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9412803 [details]
Bug 1905253 - Add a null-check in AppWindow::MoveResize. r=smaug

Beta/Release Uplift Approval Request

• User impact if declined: Startup crash
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Null check
• String changes made/needed:
• Is Android affected?: Unknown

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9412803 [details]
Bug 1905253 - Add a null-check in AppWindow::MoveResize. r=smaug

Approved for 128.0.2 and 128.1esr.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/4c5c62bac28f

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/269fbb025e79