1905380 - Migrate the extension for rendering line markers from View Plugins to State Fields

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1905380 - [devtools] Refactor lineContentMarkers to use StateFields from ViewPlugins r=#devtools-reviewers

Highlights of this patch

• Fixes the line shifting issue in the related bug as the block property can be used in Decoration.widget.
• Uses Statefields. With StateFields codemirror has more control over updates, avoiding possible crashes like in Bug 1898157
• Changes from using conditions on markers to using positions, this means we can just render the marker at the
  desired location without always needing to loop over the all the lines of the viewport. Most times the number of positions to mark
  are a lot lesser that the no of lines in the viewport.
• When explicitly updating a marker only the required decoration is updated.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4003447ea832
[devtools] Refactor lineContentMarkers to use StateFields from ViewPlugins r=devtools-reviewers,nchevobbe

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4003447ea832