1905426 - Can't return to origin of complex table after scrolling around table

Status: VERIFIED FIXED

(Core :: Layout: Scrolling and Overflow, defect, P3)

Description

[lohphat]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:127.0) Gecko/20100101 Firefox/127.0

Steps to reproduce:

Scroll around a complex table -- a Palo Alto Networks Firewall (PANOS) admin UI policy table.

Actual results:

If you scroll down away from row 1, then over to the right, when you scroll back to the left border you can't scroll back to origin (row 1). You must reload page to restore full table.

Expected results:

scroll vert and horiz freely around complex table.

Comment 1

[lohphat]

Attachment: full mozregression report

mozregression summary:

2024-06-28T09:55:06.718000: INFO : Narrowed integration regression window from [27d6cf13, 872b6e66] (3 builds) to [27d6cf13, 1bfeb41b] (2 builds) (~1 steps left)
2024-06-28T09:55:06.758000: DEBUG : Starting merge handling...
2024-06-28T09:55:06.759000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=1bfeb41be90813df378b6c822b468d51d8132536&full=1
2024-06-28T09:55:06.759000: DEBUG : redo: attempt 1/3
2024-06-28T09:55:06.759000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/integration/autoland/json-pushes?changeset=1bfeb41be90813df378b6c822b468d51d8132536&full=1',), kwargs: {}, attempt #1
2024-06-28T09:55:06.770000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2024-06-28T09:55:08.785000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /integration/autoland/json-pushes?changeset=1bfeb41be90813df378b6c822b468d51d8132536&full=1 HTTP/1.1" 200 None
2024-06-28T09:55:08.871000: DEBUG : Found commit message:
Bug 1846996: Move the test variant 'xorigin' to never expire.r=jmaher,nika

Differential Revision: https://phabricator.services.mozilla.com/D187120

2024-06-28T09:55:08.872000: DEBUG : Did not find a branch, checking all integration branches
2024-06-28T09:55:08.876000: INFO : The bisection is done.
2024-06-28T09:55:08.887000: INFO : Stopped

Comment 2

[lohphat]

The web UI is for PANOS a market leader firewall OEM. It should be relatively easy to find an appropriate testbed to reproduce the issue.

Simply load the POLICY tab and try to scroll around a larger rulebase.

PANOS version: 10.2.9-h1 on a PA-5250 NGFW

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Tables' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Gregory Pappas [:gregp]]

Reporter, do you remember roughly when you started experiencing this issue? Or has it always been happening?

Comment 5

[lohphat]

Attachment: Screenshot 2024-06-28 at 5.55.02 PM.png

Image showing origin of table visible.

Comment 6

[lohphat]

Attachment: Screenshot 2024-06-28 at 5.53.29 PM.png

This image shows that the right hand vert scollbar it at top yet table is not at top row of table. page must be reloaded for table to re-appear.

Comment 7

[lohphat]

(In reply to Gregory Pappas [:gregp] from comment #4)

Reporter, do you remember roughly when you started experiencing this issue? Or has it always been happening?

It's been buggy for a while. When I've compared against Chrome, it does not demonstrate the same behavior.

I've wanted to report earlier but didn't have a way to narrow it down. But I've learned to use the mozregression tool on two other bugs so I felt I could at least start the process with reasonable data from the tool output.

Comment 8

[Gregory Pappas [:gregp]]

Attachment: table_bug.webm

Thanks for clarifying! I think I can reproduce the issue.

Steps to reproduce:

1. Navigate to https://login.paloaltonetworks.com/live/PreRegister
2. Create an account
3. Navigate to https://jp1.demo.paloaltonetworks.com/php/login.php
4. Click "Use Single Sign-On"
5. Click "Continue"
6. Login
7. Click "Policies"
8. Scroll down a bit
9. Scroll to the right
10. Scroll to the left
11. Try to scroll back up

Actual results:
The table glitches out and cannot be scrolled to row 1

Expected results:
Table scrolls to row 1

Reporter, does this match your experience?

Comment 9

[lohphat]

BINGO!

Comment 10

[lohphat]

That strange "jitter" when scrolling is another symptom.

Comment 11

[Gregory Pappas [:gregp]]

I'm not able to reproduce the issue when layout.css.scroll-anchoring.enabled is disabled in about:config

Comment 12

[lohphat]

Confirmed workaround fixes it on MACOS with layout.css.scroll-anchoring.enabled = disabled

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:emilio, could you have a look please?

For more information, please visit BugBot documentation.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Greg, I can't repro this. After step 6 I get an SSO failure.

That said, this looks a lot like bug 1907289. Does this reproduce on the latest nightly? Maybe they are hitting the same bug.

If it does... Would it be possible to create some sort of test-case for this? The mozregression in comment 7 can't be right, since bug 1846996 was a test-only change.

Comment 15

[Gregory Pappas [:gregp]]

Hmm, I also see SSO failure, that's strange. Try https://jp1.demo.paloaltonetworks.com/php/login.php or https://jp3.demo.paloaltonetworks.com/php/login.php, I think these ones still function.

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1905426 - Refine zero-scroll-offset scroll anchoring heuristic to match blink. r=#layout

See link in the comment. We were checking both offsets, but blink only
checks one.

In this case, the page has a table with overflow-x: auto and
overflow-y: hidden. They implement a custom virtual scrolling on the
vertical axis, and scroll-anchoring interacts poorly with it.

Adapt zero-scroll-offset.html to test for this.

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Ok I figured out what's going on, in particular why the "scroll to the right" bit is needed. It's a subtle different in our scroll anchoring heuristics... The page could fix it on their end by applying overflow-anchor: none to the relevant scroller.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ccbb0036fca
Refine zero-scroll-offset scroll anchoring heuristic to match blink. r=hiro

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47248 for changes under testing/web-platform/tests

Comment 20

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6ccbb0036fca

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 22

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9413983 [details]
Bug 1905426 - Refine zero-scroll-offset scroll anchoring heuristic to match blink. r=#layout

Beta/Release Uplift Approval Request

• User impact if declined: This is a trivial fix that should help with scroll jumping in the wild.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 8 (but see the urls in follow-up comments)
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial
• String changes made/needed: none
• Is Android affected?: Yes

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a trivial fix that should help with scroll jumping in the wild.
• User impact if declined: Scroll jumping in some cases.
• Fix Landed on Version: 130
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): As small of a fix as it gets.

Comment 23

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue described in comment 8 using an old Nightly build from 2024-06-27. Verified that using latest Nightly build 130.0a1 I can't reproduce this issue across platforms (Windows 11, macOS 13.6 and Ubuntu 22.04).

Comment 24

[Donal Meehan [:dmeehan]]

Comment on attachment 9413983 [details]
Bug 1905426 - Refine zero-scroll-offset scroll anchoring heuristic to match blink. r=#layout

hg graft -er 29a40a412575

Comment 25

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/dd1318e246fc

Comment 26

[Donal Meehan [:dmeehan]]

Comment on attachment 9413983 [details]
Bug 1905426 - Refine zero-scroll-offset scroll anchoring heuristic to match blink. r=#layout

Approved for 128.1esr

Comment 27

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/a7c5b9a3dc5f

Comment 28

[Bogdan Maris, Desktop Test Engineering]

(In reply to Bogdan Maris, Desktop QA from comment #23)

Reproduced the initial issue described in comment 8 using an old Nightly build from 2024-06-27. Verified that using latest Nightly build 130.0a1 I can't reproduce this issue across platforms (Windows 11, macOS 13.6 and Ubuntu 22.04).

Also verified this as fixed using Firefox 129 beta from treeherder on the same platforms. Not marking as verified since the build for esr128 is not available yet, will verify Monday when the build with the fix will be available.

Comment 29

[Bogdan Maris, Desktop Test Engineering]

(In reply to Bogdan Maris, Desktop QA from comment #28)

(In reply to Bogdan Maris, Desktop QA from comment #23)

Reproduced the initial issue described in comment 8 using an old Nightly build from 2024-06-27. Verified that using latest Nightly build 130.0a1 I can't reproduce this issue across platforms (Windows 11, macOS 13.6 and Ubuntu 22.04).

Also verified this as fixed using Firefox 129 beta from treeherder on the same platforms. Not marking as verified since the build for esr128 is not available yet, will verify Monday when the build with the fix will be available.

Also verified using latest Firefox esr128 across platforms (Windows 11, macOS 13.6 and Ubuntu 22.04).