1905462 - Clean up in ComputeISizeValue() around the handling of aspect-ratio

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

See the patches for details.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1905462 Part 1 - Minor clean up for ComputeISizeValue. r?#layout

Rename aContainingBlockSize to aCBSize for brevity, which also matches the
parameter naming in ComputeSize() and ComputeAutoSize.

Add a helper lambda GetAvailableISize() to compute the available inline size.

Mark the ComputeISizeValue() resolving LengthPercentage as const.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1905462 Part 2 - Pass a style block size and aspect-ratio into ComputeISizeValue(). r?#layout

ComputeISizeValue() used to take StyleSizeOverrides, but

This patch reflects the fact that intrinsic inline size value such as
'min-content', 'max-content', etc. can be resolved via a definite block size and
a preferred aspect-ratio.

For the callers in nsIFrame::ComputeSize() and
nsContainerFrame::ComputeSizeWithIntrinsicDimensions(), we can pass the
styleBSize and aspectRatio that have considered the size overrides.

Also, simplify ComputeISizeValueFromAspectRatio() so that it can be reused in
other places. We'll adapt more callers in the next part. Note that the aFlags
parameter is unused, so it is removed.

This patch doesn't change behavior.

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1905462 Part 3 - Adapt more code to use ComputeISizeValueFromAspectRatio(). r?#layout

This patch doesn't change behavior.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc9c6a4c6d63
Part 1 - Minor clean up for ComputeISizeValue. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/ee962d6c71e7
Part 2 - Pass a style block size and aspect-ratio into ComputeISizeValue(). r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/475b839ecea1
Part 3 - Adapt more code to use ComputeISizeValueFromAspectRatio(). r=layout-reviewers,emilio

Comment 5

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/bc9c6a4c6d63
https://hg.mozilla.org/mozilla-central/rev/ee962d6c71e7
https://hg.mozilla.org/mozilla-central/rev/475b839ecea1