1905572 - Hard to see the close button of SearchModeSwitcher in dark mode

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Daisuke Akatsuka (:daisuke)]

Attachment: Screenshot 2024-07-01 at 13.23.26.png

I found this while reviewing bug 1903145, the close button is hard to see when in the dark mode.
Please check the attachment.

Comment 1

[Dale Harvey (:daleharvey)]

Cheers yup looks like some fill colours arent getting assigned properly there cheers. Did you mean to put the blocking bug in there? It should definitely block 1891862 thats what I was checking but this and 1903145 are independent bugs as far as I can tell so taking the depends on out

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1905572: Change the close button color for SearchModeSwitcher

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c5a33b3ce01
Change the close button color for SearchModeSwitcher r=desktop-theme-reviewers,urlbar-reviewers,daleharvey,dao

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2c5a33b3ce01

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-07-03 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 134.0a1 and Firefox 133.0 on Windows 10, Ubuntu 22, macOS 14.