Closed Bug 1905593 Opened 5 months ago Closed 4 months ago

[wpt-sync] Sync PR 46947 - Fix input type for forward delete input event

Categories

(Core :: DOM: Events, task, P4)

Product:
Core
Component:
DOM: Events
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 46947 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46947
Details from upstream follow.

Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com> wrote:

Fix input type for forward delete input event

A |TypingCommand| is created to execute corresponding input command and
and is reused until it is open for typing.
|TypingCommand::ForwardDeleteKeyPressed()| was reusing last typing
command without resetting its input type, which is fixed in this CL.

Bug: 40736701
Change-Id: I5ca6ed8c3028c90cd32a4d206772bcf9a5d48b2b
Reviewed-on: https://chromium-review.googlesource.com/5653570
WPT-Export-Revision: 1a372cea1461d58e7ddbf95f16262e9168b24bc0

Component: web-platform-tests → DOM: Events
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 12 subtests

Status Summary

Firefox

OK : 1
PASS: 8
FAIL: 4

Chrome

OK : 1
PASS: 9
FAIL: 3

Safari

OK : 1
PASS: 4
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /input-events/input-events-typing.html [wpt.fyi]
    • It triggers beforeinput and input events on typing DELETE with pre-existing content: FAIL (Chrome: PASS, Safari: PASS)
    • It triggers beforeinput and input events on typing DELETE with no pre-existing content: FAIL (Chrome: FAIL, Safari: FAIL)
    • It triggers beforeinput and input events on typing BACK_SPACE with no pre-existing content: FAIL (Chrome: FAIL, Safari: FAIL)
    • It triggers beforeinput and input events on typing Undo and Redo key combinations without an existing history: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb2aee6695d1 [wpt PR 46947] - Fix input type for forward delete input event, a=testonly

https://hg.mozilla.org/mozilla-central/rev/eb2aee6695d1

Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.