1905606 - Fix StyleEditor onStyleApplied frequent intermittents due to throttling

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, task)

Description

[Julian Descottes [:jdescottes]]

Resource throttling seems to make the Style Editor tests fail in various ways. This one occurs when we try to fetch source text while the style editor has already been destroyed.

Comment 1

[Julian Descottes [:jdescottes]]

Repurposing to fix another issue, frequently affecting beta

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1905606 - [devtools] Silence StyleSheetEditor errors when calling _fetchSourceText during destroy

Causes very frequent intermittent failures on macos.
The other callsite for _fetchSourceText is also having a similar try catch.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1905606 - [devtools] Silence StyleSheetEditor errors when calling _fetchSourceText during destroy

Causes very frequent intermittent failures on macos.
The other callsite for _fetchSourceText is also having a similar try catch.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1905606 - [devtools] Check if editor is still available in StyleEditorUI onResourceUpdated

Depends on D215321

Causes very frequent intermittent failures on Windows + Beta (see https://bugzilla.mozilla.org/show_bug.cgi?id=1905540)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/438ec8e10f5a
[devtools] Silence StyleSheetEditor errors when calling _fetchSourceText during destroy r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/bea9f04b1ffd
[devtools] Check if editor is still available in StyleEditorUI onResourceUpdated r=devtools-reviewers,nchevobbe

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/438ec8e10f5a
https://hg.mozilla.org/mozilla-central/rev/bea9f04b1ffd