Allow buffering of frames in AAudio input callbacks
Categories
(Core :: Audio/Video: cubeb, defect, P2)
Tracking
()
People
(Reporter: pehrsons, Assigned: pehrsons)
References
Details
Attachments
(1 file, 1 obsolete file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-release+
|
Details | Review |
We set the frames per data callback to the requested latency. We also set the buffer size to 3x the burst size.
These don't always align, and perhaps more importantly, the buffer size may end up smaller than the frames per data callback.
In addition to this, we also set the buffer capacity to the requested latency. Note that the frames per data callback setter docs say to set the buffer capacity to at least 2x the frames per data callback.
This could be the root cause of bug 1882846, so marking this a blocker.
|
Assignee | |
Comment 1•8 months ago
|
||
|
|
Assignee | |
Comment 2•8 months ago
|
||
|
|
Assignee | |
Updated•8 months ago
|
|
||
Comment 4•8 months ago
|
||
| bugherder | ||
|
||
Comment 5•7 months ago
•
|
||
Comment on attachment 9410457 [details]
Bug 1905636 - Update libcubeb to 5d5008d25c. r?#cubeb-reviewers!
Uplifting bug 1877948 depends on this patch.
Beta/Release Uplift Approval Request
- User impact if declined: Background noise when recording audio.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The changes are simple.
- String changes made/needed:
- Is Android affected?: Yes
|
||
Comment 6•7 months ago
|
||
Comment on attachment 9410457 [details]
Bug 1905636 - Update libcubeb to 5d5008d25c. r?#cubeb-reviewers!
Approved for 128.0.2.
|
|
||
Updated•7 months ago
|
Description
•