1905653 - Escape inside template literals gets lost by prettify

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Tooru Fujisawa [:arai]]

Attachment: testcase

Steps to reproduce:

1. Run Nightly 129.0a1 (2024-06-30) (64-bit) with clean profile on macOS
2. Open the attached file
3. Open DevTools Debugger and select the HTML file
4. Click prettify button

Actual result:

The JS code is prettified like the following, where backslashes inside the template literal get lost and results in an invalid code

(the attached file contains unnecessary RegExp literal. please ignore it)

(function () {
  return `foo `bar` baz \1`;
}) ();

Expected result:

The JS code is prettified like the following:

(function () {
  return `foo \`bar\` baz \\1`;
}) ();

This comes from the template literal not being handled by PrettyFast.#writeToken

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1905653 - Part 1: Handle template literals in pretty-fast. r?#devtools-reviewers!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1905653 - Part 1: Handle template literals in pretty-fast. r?#devtools-reviewers!

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1905653 - Part 2: Bundle pretty-print-worker.js. r?#devtools-reviewers!

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1905653 - Part 2: Bundle pretty-print-worker.js. r?#devtools-reviewers!

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1905653 - Part 3: Add tests for template literals in pretty print. r?#devtools-reviewers!

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1905653 - Part 3: Add tests for template literals in pretty print. r?#devtools-reviewers!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b55060e097ca
Part 1: Handle template literals in pretty-fast. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/b833ffa9f4bc
Part 2: Bundle pretty-print-worker.js. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8659368edf0d
Part 3: Add tests for template literals in pretty print. r=devtools-reviewers,nchevobbe

Comment 8

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/b55060e097ca
https://hg.mozilla.org/mozilla-central/rev/b833ffa9f4bc
https://hg.mozilla.org/mozilla-central/rev/8659368edf0d