1905751 - [wpt-sync] Sync PR 46953 - [reading-flow] Display: contents elements can be focusable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46953 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46953
Details from upstream follow.

Di Zhang <[e-mail]> wrote:

[reading-flow] Display: contents elements can be focusable

CSSWG has resolved that reading-flow does not affect whether an element
is focusable. Given this, we should remove the check in Element that
forbids display: contents with reading-flow to be focusable.

We update the FocusNavigation logic such that the display: contents
elements are visited last, after all reading flow items found within the
layout box.

Change-Id: Iadd9636166628361b001df7b63b2ee98072a89d5
Bug: 346979043
Reviewed-on: https://chromium-review.googlesource.com/5656691
WPT-Export-Revision: 69dd61fc66654174af74c33fec59b3feeafa6bb5

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d6563f476e0437d6aeaec380a70fdabf013ed50

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 6 subtests

Status Summary

Firefox

OK : 4
PASS: 1
FAIL: 15

Chrome

OK : 4
PASS: 14
FAIL: 2

Safari

OK : 4
FAIL: 16

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /shadow-dom/focus-navigation/reading-flow/tentative/grid-order-across-scopes.html [wpt.fyi]
  • Grid items in shadow host that is a display contents grid item: FAIL (Chrome: FAIL, Safari: FAIL)
• /shadow-dom/focus-navigation/reading-flow/tentative/grid-order-on-shadow-host.html [wpt.fyi]
  • Grid items in shadow host with delegatesFocus: FAIL (Chrome: PASS, Safari: FAIL)
  • Grid items in shadow host without delegatesFocus: FAIL (Chrome: PASS, Safari: FAIL)
• /shadow-dom/focus-navigation/reading-flow/tentative/grid-order-with-slots.html [wpt.fyi]
  • Slot assigned element is a grid with reading-flow.: FAIL (Chrome: PASS, Safari: FAIL)
  • Slot is a grid with reading-flow.: FAIL (Chrome: PASS, Safari: FAIL)
  • Slot is inside a grid container with reading-flow.: FAIL (Chrome: PASS, Safari: FAIL)
  • Slot is a grid with reading-flow inside a grid container with reading-flow.: FAIL (Chrome: PASS, Safari: FAIL)
  • Slot is not inside a shadow host.: FAIL (Chrome: PASS, Safari: FAIL)
  • Slot is a display contents inside a grid container.: FAIL (Chrome: PASS, Safari: FAIL)
  • Slot is a display block inside a grid container.: FAIL (Chrome: PASS, Safari: FAIL)
• /shadow-dom/focus-navigation/reading-flow/tentative/grid-order.html [wpt.fyi]
  • Grid items with order property: FAIL (Chrome: PASS, Safari: FAIL)
  • Grid items with order property and tabindex: FAIL (Chrome: PASS, Safari: FAIL)
  • Items in display contents are sorted in same grid container.: FAIL (Chrome: PASS, Safari: FAIL)
  • Items in display contents are sorted in same grid container, with focusable display contents divs at the end of the focus sequence.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Items in display block are not in parent grid container.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f66ad77cf877
[wpt PR 46953] - [reading-flow] Display: contents elements can be focusable, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d6c7eb376f04
[wpt PR 46953] - Update wpt metadata, a=testonly

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/f66ad77cf877
https://hg.mozilla.org/mozilla-central/rev/d6c7eb376f04