1905808 - Library info pane missing spacing on macOS

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Sam Johnson]

After bug 1881256, the inputs in the Library window on macOS are no longer spaced apart. It looks like a lot of the info pane styling can be consolidated, which will fix this.

Comment 1

[Sam Johnson]

Attachment: Bug 1905808 - Consolidate organizer info pane styles, use nesting. r?#desktop-theme-reviewers

The general layout of the info pane is the same across platforms, so share the styles. This fixes the missing spacing on macOS after bug 1881256. Due to the changes in that bug, Windows no longer needs its own input styling, as it achieves the same appearance as the base styles (except for colors, which have been carried over).

Applied nesting to modified files.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1881256

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1881256

Comment 4

[Donal Meehan [:dmeehan]]

Sam, the Fx130 nightly cycle has just started. Are you aiming to land this patch shortly?
S4 bug from an older release, doesn't look like we should uplift it but let me know if you think otherwise.

Comment 5

[Sam Johnson]

The patch still needs review. Once approved, I will need assistance landing as I do not have that access level.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7163f4467da0
Consolidate organizer info pane styles, use nesting. r=desktop-theme-reviewers,places-reviewers,dao,mak

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7163f4467da0

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR128 approval. It grafts cleanly.

Comment 9

[Sam Johnson]

Attachment: Bug 1905808 - Consolidate organizer info pane styles, use nesting.

The general layout of the info pane is the same across platforms, so share the styles. This fixes the missing spacing on macOS after bug 1881256. Due to the changes in that bug, Windows no longer needs its own input styling, as it achieves the same appearance as the base styles (except for colors, which have been carried over).

Applied nesting to modified files.

Original Revision: https://phabricator.services.mozilla.com/D215464

Comment 10

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Text inputs on the Library window on macOS will be touching rather than spaced apart
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Open the Library window, and select a bookmark. The text inputs in the info pane should not be touching.
• Risk associated with taking this patch: Low
• Explanation of risk level: Minor CSS change
• String changes made/needed: None
• Is Android affected?: no

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/1533833f1578

Comment 12

[Simona Badau, Desktop QA]

Reproduced the initial issue on Firefox 127 (Build ID: 20240606181944) on macOS 13.

Verified as fixed using Firefox 128.2.0esr, Firefox 130 beta and Nightly 131.0a1.