1905889 - Update user prompt handler behavior based on GitHub PR 1819

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The following PR on GitHub changes the behavior of the unhandledPromptBehavior capability:

• Make string valued handlers only set the alert/confirm/prompt modals, but object valued handlers with a default key set the default for all prompt types including beforeUnload
• Unconditionally return the user prompt handler in the new session response

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The upstream PR got merged. We potentially should work on those changes in M12.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Updates for tests were provided upstream and got synced downstream via bug 1907349. Updated meta-data this bug needs to take care of are in:

• https://hg.mozilla.org/integration/autoland/rev/e025d0eefbbe

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As spoken with Julian he is going to work on this bug. As first step he created a PR to fix some smaller inconsistencies:
https://github.com/w3c/webdriver/pull/1831

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1905889 - [remote] Update user prompt handler behavior based on GitHub PR 1819

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6a63f747d6d
[remote] Update user prompt handler behavior based on GitHub PR 1819 r=webdriver-reviewers,whimboo

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b6a63f747d6d