Closed
Bug 1905899
Opened 3 months ago
Closed 3 months ago
Refactor code for computed panel
Categories
(DevTools :: Inspector, task)
DevTools
Inspector
Tracking
(firefox129 fixed)
RESOLVED
FIXED
129 Branch
| Tracking | Status | |
|---|---|---|
| firefox129 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
Attachments
(10 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
No description provided.
|
Assignee | |
Comment 1•3 months ago
|
||
|
||
Updated•3 months ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•3 months ago
|
||
|
|
Assignee | |
Comment 3•3 months ago
|
||
|
|
Assignee | |
Comment 4•3 months ago
|
||
Use proper private properties and methods, and avoid
throwing to indicate when the batch is done.
|
|
Assignee | |
Comment 5•3 months ago
|
||
|
|
Assignee | |
Comment 6•3 months ago
|
||
|
|
Assignee | |
Comment 7•3 months ago
|
||
|
|
Assignee | |
Comment 8•3 months ago
|
||
|
|
Assignee | |
Comment 9•3 months ago
|
||
|
|
Assignee | |
Comment 10•3 months ago
|
||
|
||
Comment 11•3 months ago
|
||
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62a3ee047233 [devtools] Avoid unnecessary work in PageStyleActor#getComputed. r=devtools-reviewers,ochameau. https://hg.mozilla.org/integration/autoland/rev/aedffc413a03 [devtools] Turn CssComputedView#refreshPanel into an async function. r=devtools-reviewers,ochameau. https://hg.mozilla.org/integration/autoland/rev/3bc34637372a [devtools] Make computed.js classes into proper ES6 classes. r=devtools-reviewers,bomsy. https://hg.mozilla.org/integration/autoland/rev/f9d0374ff1e5 [devtools] Refactor computed.js UpdateProcess. r=devtools-reviewers,ochameau. https://hg.mozilla.org/integration/autoland/rev/51f2536bf9a9 [devtools] Use proper private fields in CssComputedView. r=devtools-reviewers,ochameau. https://hg.mozilla.org/integration/autoland/rev/c0174685c26c [devtools] Use proper private fields in SelectorView. r=devtools-reviewers,ochameau. https://hg.mozilla.org/integration/autoland/rev/fc728b2bb024 [devtools] Use proper private fields in PropertyView. r=devtools-reviewers,ochameau. https://hg.mozilla.org/integration/autoland/rev/1fbb9e6705dc [devtools] Use AbortController for managing event listeners in ComputedViewTool. r=devtools-reviewers,ochameau. https://hg.mozilla.org/integration/autoland/rev/f4925042c033 [devtools] Use AbortController for managing event listeners in CssComputedView. r=devtools-reviewers,ochameau. https://hg.mozilla.org/integration/autoland/rev/6090a462d1c0 [devtools] Make properties private when possible in computed.js. r=devtools-reviewers,bomsy.
|
||
Comment 12•3 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/62a3ee047233
https://hg.mozilla.org/mozilla-central/rev/aedffc413a03
https://hg.mozilla.org/mozilla-central/rev/3bc34637372a
https://hg.mozilla.org/mozilla-central/rev/f9d0374ff1e5
https://hg.mozilla.org/mozilla-central/rev/51f2536bf9a9
https://hg.mozilla.org/mozilla-central/rev/c0174685c26c
https://hg.mozilla.org/mozilla-central/rev/fc728b2bb024
https://hg.mozilla.org/mozilla-central/rev/1fbb9e6705dc
https://hg.mozilla.org/mozilla-central/rev/f4925042c033
https://hg.mozilla.org/mozilla-central/rev/6090a462d1c0
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox129:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•