Open Bug 1905929 Opened 1 year ago Updated 1 year ago

When capturing the profile from a signal handler, consider dumping profiles to <profile_name>.partial files to indicate an incomplete profile (and then rename at the end)

Categories

(Core :: Gecko Profiler, task, P3)

Product:
Core
Component:
Gecko Profiler
Type:
task

Tracking

()

People

(Reporter: aabh, Unassigned)

References

(Blocks 1 open bug)

Details

While working on Bug 1883903, we've experienced situations where the profiler is correctly started and stopped, but only writes a partial/truncated profile file to disk. A short term solution to this is to make the CI wait for a set period of time after stopping the profiler, but it does highlight that we currently have no way to tell if the profiler has "finished" writing a profile when it is stopped using a POSIX signal.

To make it clear when we are finished, we should instead write incomplete profiles to a "<name>.partial" file, which we can rename to "<name>.profile" (or similar) once we have finished writing.

Summary: Consider dumping profiles to <profile_name>.partial files to indicate an incomplete profile while stopping the profiler with a signal. → When capturing the profile from a signal handler, consider dumping profiles to <profile_name>.partial files to indicate an incomplete profile (and then rename at the end)
See Also: → 1906151
Severity: -- → N/A
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.