1905964 - VS2022 doesn't support deprecated ext/hash_map

Status: NEW

(SeaMonkey :: Build Config, defect)

Description

[Matt A. Tobin [:nsITobin]]

This has been deprecated for some time and I guess finally removed in VS2022.

0:53.37 In file included from Unified_cpp_src_media-conduit0.cpp:56:
0:53.37 In file included from d:/binoc/workstation/projects/mozilla-253/media/webrtc/signaling/src/media-conduit/WebrtcediaDataDecoderCodec.cpp:11:
0:53.38 In file included from d:/binoc/workstation/projects/.obj/seamonkey-x86_64-pc-mingw32/dist/include\mozilla/layer/ImageBridgeChild.h:15:
0:53.39 In file included from d:/binoc/workstation/projects/.obj/seamonkey-x86_64-pc-mingw32/dist/include\mozilla/ipc/SaredMemory.h:15:
0:53.40 In file included from d:/binoc/workstation/projects/mozilla-253/ipc/chromium/src\chrome/common/ipc_message_util.h:14:
0:53.41 In file included from d:/binoc/workstation/projects/mozilla-253/ipc/chromium/src\base/file_path.h:74:
0:53.42 In file included from d:/binoc/workstation/projects/mozilla-253/ipc/chromium/src\base/hash_tables.h:39:
0:53.42 C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1439~1.335\include\hash_map(111,50): error: no template named hash_compare'; did you mean 'std::_Uhash_compare'?
0:53.43     template <class _Kty, class _Ty, class _Tr = hash_compare<_Kty, _STD less<_Kty>>,
0:53.44                                                  ^
0:53.44 C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1439~1.335\include\xhash(123,7): note: 'std::_Uhash_compare' dclared here
0:53.45 class _Uhash_compare

The Unified XUL Platform has a unique solution using std::unsorted_map instead and should work until Bug 1641090 hits the patchqueue.

Comment 1

[Matt A. Tobin [:nsITobin]]

Attachment: [GitDiff] Bug 1905962 - Use std::unsorted_map instead of hash_map in ipc

Author: Brian Smith <[e-mail]>

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9410890 [details] [diff] [review]
[GitDiff] Bug 1905962 - Use std::unsorted_map instead of hash_map in ipc

Hi Tobin looks like you attachted the wrong patch

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: TOP-1905964-25320.patch

Please check

Comment 4

[Matt A. Tobin [:nsITobin]]

It is identical to the CORRECT patch I should have attached.