1905975 - Remove the old button story in Storybook

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • Here is a more detailed tutorial for getting set up to work on Firefox
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
3. Start working on this bug.
   • You will need to delete the button.stories.mjs file since it is no longer needed.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and verify your change with mach storybook. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!

Comment 1

[Louis Mascari]

Hey there I'm a new contributor and will be working on this bug, thanks.

Comment 2

[Louis Mascari]

Hey Tim - I deleted the file and attempted to commit however the message I receive in the terminal when doing so is "nothing changed (1 missing files, see 'hg status'). When running hg wip after it appears a new branch hasn't been created and I am unable to successfully run moz-phab and am given a "Failed to find draft commits to submit" response. What's the process when the change involves only deleting 1 file? It doesn't seem to be picked up by hg dif either. Thanks in advance.

Comment 3

[Tim Giles [:tgiles]]

Hmm, that's odd. How did you delete the file? Did you use hg remove? I'm not too proficient with mercurial, but it seems like hg remove should be the way to go.

Comment 4

[Louis Mascari]

Attachment: Bug 1905975 - Remove the old button story in Storybook. r?tgiles!

Comment 5

[Louis Mascari]

I had originally deleted it manually in vscode, I guess I'm too used to git where I would have been able to commit that change. Thank you for passing that link to me, that did seem to work.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/847301b48b94
Remove the old button story in Storybook. r=tgiles

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/847301b48b94