1906003 - PPA API - Fix async issue in JS Module

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Comment 1

[Brendan Birdsong]

Attachment: Bug 1906003 - PPA API - Fix async issue in JS Module r=cbguder,dmueller,mt

Comment 2

[Brendan Birdsong]

Attachment: Bug 1906003 - PPA API - Fix async issue in JS Module r=cbguder,dmueller,mt

This change fixes a bug in the PPA API's that causes multiple source/target impressions not to store properly in the data store due to a promise being returned instead of the evaluation of the statement in the compareImpression function. This causes an issue where we cannot handle multiple ads / suppliers running at the same time.

The plan is to release this in the Fx 128 dot release.

Original Revision: https://phabricator.services.mozilla.com/D215656

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47bbb7c19fec
PPA API - Fix async issue in JS Module r=cbguder

Comment 4

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: We will miss some of our testing dates and need to wait until Fx 129 to test with the API. Implementers will also need to add additional code to not call the API if the Firefox version is 128.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: There should be no risk with taking this patch.
• Explanation of risk level: The API currently has a limited audience and Mozilla is working closely with advertisers/publishers to experiment with the API.
• String changes made/needed: No
• Is Android affected?: no

Comment 5

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/47bbb7c19fec

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/6b34cec4ff33

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr128/rev/6b34cec4ff33