1906008 - [wpt-sync] Sync PR 46974 - [SAA] refactor handling for code shared between rSA and rSA-extension

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46974 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46974
Details from upstream follow.

Ari Chivukula <[e-mail]> wrote:

[SAA] refactor handling for code shared between rSA and rSA-extension

Turns out one needs to explicitly handle the rejection and not just
assume it bubbles up to the top. This makes sense given it would be bad
for web facing code to assume any error seen could be passed directly on
to the console.

This refactor allows logic to be shared between the two paths.

Fixed: 350653957
Change-Id: Ib0c7352c669641debbb177525746b8d9f7b7ebc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5670735
Auto-Submit: Ari Chivukula \<[e-mail]>
Reviewed-by: Chris Fredrickson \<[e-mail]>
Commit-Queue: Ari Chivukula \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1322451}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9835c0182a56397bd0cd9425f4c4e6f1b93b335

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests and 1 subtests

Status Summary

Firefox

OK : 12
FAIL : 12

Chrome

OK : 11
PASS : 10
FAIL : 1
TIMEOUT: 1
ERROR : 1

Safari

TIMEOUT: 23
ERROR : 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /storage-access-api/storage-access-beyond-cookies.BroadcastChannel.tentative.sub.https.window.html [wpt.fyi]
  • Verify StorageAccessAPIBeyondCookies for Broadcast Channel: FAIL (Chrome: PASS, Safari: TIMEOUT)
• /storage-access-api/storage-access-beyond-cookies.SharedWorker.tentative.sub.https.window.html [wpt.fyi]
  • Verify StorageAccessAPIBeyondCookies for Shared Worker: FAIL (Chrome: TIMEOUT, Safari: TIMEOUT)
• /storage-access-api/storage-access-beyond-cookies.blobStorage.tentative.sub.https.window.html [wpt.fyi]
  • Verify StorageAccessAPIBeyondCookies for Blob Storage: FAIL (Chrome: PASS, Safari: TIMEOUT)
• /storage-access-api/storage-access-beyond-cookies.caches.tentative.sub.https.window.html [wpt.fyi]
  • Verify StorageAccessAPIBeyondCookies for Cache Storage: FAIL (Chrome: PASS, Safari: TIMEOUT)
• /storage-access-api/storage-access-beyond-cookies.cookies.tentative.sub.https.window.html [wpt.fyi]
  • Verify StorageAccessAPIBeyondCookies for Cookies: FAIL (Chrome: FAIL, Safari: TIMEOUT)
• /storage-access-api/storage-access-beyond-cookies.estimate.tentative.sub.https.window.html [wpt.fyi]
  • Verify StorageAccessAPIBeyondCookies for Quota: FAIL (Chrome: PASS, Safari: TIMEOUT)
• /storage-access-api/storage-access-beyond-cookies.getDirectory.tentative.sub.https.window.html [wpt.fyi]
  • Verify StorageAccessAPIBeyondCookies for Origin Private File System: FAIL (Chrome: PASS, Safari: TIMEOUT)
• /storage-access-api/storage-access-beyond-cookies.indexedDB.tentative.sub.https.window.html [wpt.fyi]
  • Verify StorageAccessAPIBeyondCookies for IndexedDB: FAIL (Chrome: PASS, Safari: TIMEOUT)
• /storage-access-api/storage-access-beyond-cookies.localStorage.tentative.sub.https.window.html [wpt.fyi]
  • Verify StorageAccessAPIBeyondCookies for Local Storage: FAIL (Chrome: PASS, Safari: TIMEOUT)
• /storage-access-api/storage-access-beyond-cookies.locks.tentative.sub.https.window.html [wpt.fyi]
  • Verify StorageAccessAPIBeyondCookies for Web Locks: FAIL (Chrome: PASS, Safari: TIMEOUT)
• /storage-access-api/storage-access-beyond-cookies.none.tentative.sub.https.window.html [wpt.fyi]
  • Verify StorageAccessAPIBeyondCookies for None: FAIL (Chrome: PASS, Safari: TIMEOUT)
• /storage-access-api/storage-access-beyond-cookies.sessionStorage.tentative.sub.https.window.html [wpt.fyi]
  • Verify StorageAccessAPIBeyondCookies for Session Storage: FAIL (Chrome: PASS, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e18bd387a072
[wpt PR 46974] - [SAA] refactor handling for code shared between rSA and rSA-extension, a=testonly

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/e18bd387a072