1906015 - Avoid QI from `nsINode*` to `nsCOMPtr<nsIFormControl>`

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

While I'm investigating another bug, I found a lot of QI from nsINode* to nsCOMPtr<nsIFormControl>. I think we can get rid of them.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1906015 - part 1: Add `nsIFormControl` accessors from `nsINode*` or `EventTarget*` r=smaug!

Although the following patch do not use the dom::EventTarget* versions,
they should be available for consistency with the other FromNode related
utility methods.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1906015 - part 2: Make the most `do_QueryInterface` users for `nsIFormControl` use new getter methods r=smaug!

Unfortunately, the following QIs are still required.
https://searchfox.org/mozilla-central/rev/cbdfa503a87597b20719aae5f6a1efccd6cb3b7b/dom/html/nsIConstraintValidation.cpp#101,121

Depends on D215576

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

farre: could you review attachment 9410936 [details]? It's a simple refactoring entire the nsIFormControl interface users.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Isn't that already reviewed (by me :) ) ?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug][[e-mail]](vacation until July 14) from comment #4)

Isn't that already reviewed (by me :) ) ?

Err, it's about attachment 9410937 [details] which requires a review of #sessionstore-reviewers.

Well, farre is now in a long PTO, so, redirecting the ni? to Sarah Clements.

Hello, Sarah, could you review the patch as a member of #sessionstore-reviewers? It's a simple refactoring patch without any logical changes.

Comment 6

[Sarah Clements [:sclements]]

Hi :masayuki, I did r+ that but in the future it'd be helpful to explain the session restore changes more clearly (the current session restore owners are frontend-end based in our knowledge of session restore, so its out of my wheelhouse).

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4621950d1f80
part 1: Add `nsIFormControl` accessors from `nsINode*` or `EventTarget*` r=smaug
https://hg.mozilla.org/integration/autoland/rev/897825504e5d
part 2: Make the most `do_QueryInterface` users for `nsIFormControl` use new getter methods r=smaug,credential-management-reviewers,sessionstore-reviewers,sclements

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4621950d1f80
https://hg.mozilla.org/mozilla-central/rev/897825504e5d