1906032 - Perma [clang-trunk] mingw js/src/util/Text.h:39:15: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Mike Hommey [:glandium]]

[task 2024-07-03T01:04:52.960Z] 01:04:52    ERROR -  /builds/worker/checkouts/gecko/js/src/util/Text.h:39:15: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
[task 2024-07-03T01:04:52.961Z] 01:04:52     INFO -     39 |   return std::char_traits<CharT>::length(s);
[task 2024-07-03T01:04:52.961Z] 01:04:52     INFO -        |               ^
[task 2024-07-03T01:04:52.961Z] 01:04:52     INFO -  /builds/worker/checkouts/gecko/js/src/jsapi-tests/testStringBuffers.cpp:15:29: note: in instantiation of function template specialization 'js_strlen<unsigned char>' requested here
[task 2024-07-03T01:04:52.962Z] 01:04:52     INFO -     15 |   static const size_t len = js_strlen(chars);
[task 2024-07-03T01:04:52.962Z] 01:04:52     INFO -        |                             ^
[task 2024-07-03T01:04:52.962Z] 01:04:52     INFO -  /builds/worker/fetches/clang/bin/../x86_64-w64-mingw32/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
[task 2024-07-03T01:04:52.963Z] 01:04:52     INFO -     45 | struct char_traits;
[task 2024-07-03T01:04:52.963Z] 01:04:52     INFO -        |        ^
[task 2024-07-03T01:04:52.963Z] 01:04:52     INFO -  2 warnings and 1 error generated.
[task 2024-07-03T01:04:52.964Z] 01:04:52    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:675: Unified_cpp_js_src_jsapi-tests21.o] Error 1

https://treeherder.mozilla.org/logviewer?job_id=464952707&repo=toolchains&lineNumber=167662

See bug 1890905 for an earlier instance of a similar problem.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1903037

:jandem, since you are the author of the regressor, bug 1903037, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1906032 - Don't use deprecated std::char_traits<unsigned char> in js_strlen. r?sfink!

Newer Clang versions don't have the base template that works with unsigned char:
https://releases.llvm.org/16.0.0/projects/libcxx/docs/ReleaseNotes.html#upcoming-deprecations-and-removals

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0703b232211
Don't use deprecated std::char_traits<unsigned char> in js_strlen. r=sfink

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d0703b232211

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1903037