1906041 - Add QuotaManager::Initialize(Persistent|Temporary)Origin methods

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1906041 - Simplify signature of QuotaManager::EnsureTemporaryOriginIsInitialized; r=#dom-storage

EnsureTemporaryOriginIsInitialized currently takes two separate arguments which
can be expressed as just one argument.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1906041 - Rename Ensure(Persistent|Temporary)OriginIsInitialized to Ensure(Persistent|Temporary)OriginIsInitializedInternal; r=#dom-storage

One of the goals of the asynchronous temporary storage initialization is to
call Ensure(Persistent|Temporary)OriginIsInitialized only from
Initialize(Persistent|Temporary)OriginOp. Calling from other places including
quota clients will be disallowed by changing the method to a private method.
The private nature of the method should be emphasized by adding the Internal
suffix.

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1906041 - Add QuotaManager::Initialize(Persistent|Temporary)Origin methods; r=#dom-storage

There are currently EnsurePersistentOriginIsInitializedInternal and
EnsureTemporaryOriginIsInitializedInternal methods which can only be
called on the QuotaManager IO thread. These methods shouldn't be exposed to
quota clients and origin operations. There should be public methods callable
from the PBackground thread returning a MozPromise instead. Such methods will
guarantee that proper directory locking is acquired before persistent origin
initialization or temporary origin initialization is started.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b20ab069dd7c
Simplify signature of QuotaManager::EnsureTemporaryOriginIsInitialized; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/0c5b7b4f368c
Rename Ensure(Persistent|Temporary)OriginIsInitialized to Ensure(Persistent|Temporary)OriginIsInitializedInternal; r=dom-storage-reviewers,jari

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/b20ab069dd7c
https://hg.mozilla.org/mozilla-central/rev/0c5b7b4f368c

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c5c939030c7
Add QuotaManager::Initialize(Persistent|Temporary)Origin methods; r=dom-storage-reviewers,jari

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5c5c939030c7