1906047 - Move more test files to be under directories named test

Status: RESOLVED FIXED

(Toolkit :: General, task, P3)

Description

[Mark Banner (:standard8)]

I've just noticed that we have a few directories that are containing tests, but are not under a /test/ or /tests/ directory.

This has a couple of effects:

• ESLint can't apply the general-test configuration.
• Searchfox can't identify these files as tests.

The affected directories are:

• devtools/client/shared/redux/middleware/xpcshell/
• intl/benchmarks/
• toolkit/profile/xpcshell/

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1906047 - Move devtools/client/shared/redux/middleware/xpcshell/ to be in a test sub-directory. r?#devtools-reviewers!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1906047 - Move intl/benchmarks/ to be in a test sub-directory. r?hsivonen!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1906047 - Move toolkit/profile/ tests into a test sub-directory. r?Mossop!

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1906047 - Remove ESLint workaround for importing headjs globals now that the test directories have been fixed. r?#frontend-codestyle-reviewers!

The general-test configuration applies this rule for all tests.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e67c8cb4c716
Move devtools/client/shared/redux/middleware/xpcshell/ to be in a test sub-directory. r=devtools-reviewers,frontend-codestyle-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/89d9a9a60b82
Move intl/benchmarks/ to be in a test sub-directory. r=hsivonen,frontend-codestyle-reviewers
https://hg.mozilla.org/integration/autoland/rev/87f1ceadf115
Move toolkit/profile/ tests into a test sub-directory. r=mossop
https://hg.mozilla.org/integration/autoland/rev/b94db0e16ac7
Remove ESLint workaround for importing headjs globals now that the test directories have been fixed. r=frontend-codestyle-reviewers,Gijs

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e67c8cb4c716
https://hg.mozilla.org/mozilla-central/rev/89d9a9a60b82
https://hg.mozilla.org/mozilla-central/rev/87f1ceadf115
https://hg.mozilla.org/mozilla-central/rev/b94db0e16ac7