1906054 - SearchModeSwitcher icon is not updated when default search engine changes

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Comment 1

[Karandeep Lubana [:klubana]]

Attachment: Bug 1906054 - SearchModeSwitcher icon is not updated when default search engine changes. r=daleharvey

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34cf7e724994
SearchModeSwitcher icon is not updated when default search engine changes. r=daleharvey

Comment 3

[tszentpeteri]

Backed out for causing mochitest failures on browser_searchMode_preview.js

• Backout link
• Push with failures
• Failure Log:

[task 2024-07-31T12:15:40.383Z] 12:15:40     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_searchMode_preview.js | gURLBar does not have searchmodesource attribute - true == true - 
[task 2024-07-31T12:15:40.384Z] 12:15:40     INFO - Buffered messages finished
[task 2024-07-31T12:15:40.385Z] 12:15:40     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_searchMode_preview.js | Expected searchMode - {"engineName":"Google","isGeneralPurposeEngine":true,"source":3,"isPreview":true,"entry":"topsites_urlbar"} deepEqual {"engineName":"Google","isPreview":true,"entry":"topsites_urlbar","isGeneralPurposeEngine":true} - 
[task 2024-07-31T12:15:40.385Z] 12:15:40     INFO - Stack trace:
[task 2024-07-31T12:15:40.385Z] 12:15:40     INFO - resource://testing-common/UrlbarTestUtils.sys.mjs:assertSearchMode:899
[task 2024-07-31T12:15:40.385Z] 12:15:40     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_searchMode_preview.js:topSites:152
[task 2024-07-31T12:15:40.385Z] 12:15:40     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-07-31T12:15:40.385Z] 12:15:40     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-07-31T12:15:40.385Z] 12:15:40     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-07-31T12:15:40.386Z] 12:15:40     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-07-31T12:15:40.386Z] 12:15:40     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-07-31T12:15:40.389Z] 12:15:40     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_searchMode_preview.js | Expected textContent - "Google" == "Google" - 

Comment 4

[Karandeep Lubana [:klubana]]

Attachment: Bug 1906054 - SearchModeSwitcher icon is not being updated when default search engine changes. r=daleharvey

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc622ed73e96
SearchModeSwitcher icon is not being updated when default search engine changes. r=daleharvey

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/cc622ed73e96