1906110 - Focusing the urlbar with the mouse sometimes doesn't select all because the URL shifts due to icons inserted/removed before it

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Marco Bonardo [:mak]]

Clicking on the urlbar to focus it, should normally Select All, so its contents are ready to be replaced.
Unfortunately often this doesn't work and I end up inserting some text in the middle of the URL.
I found this is due to a few (1px, 2px) mousemove between mousedown and mouseup, that I may inadvertently do.
This is normally not a problem, but because the URL shifts when we insert or remove icons before it, we end up causing a selection change (the mouse moved by 1 px, the url moved by many pixels, so now 1-3 characters are selected).

Other browsers solved this by not shifting the url between focused and unfocused state, though that means we can only have a fixed amount of space for icons before the url, we cannot dynamically insert or remove icons then.
Possible solutions to evaluate:

1. don't collapse/uncollapse icons on focus change if mousedown. We can probably do this with a mousedown attribute and changing a few focused css rules. Icons would instead appear/disappear on mouseup
2. we could ignore small mousemove (less than half of a character) when passing from focused to unfocused... this may potentially prevent some wanted selection change, or not catch larger mousemove that users with accessibility problems may do

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1906110 - Address bar content shifts when focusing on mousedown. r=jteow

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1d771b15d44
Address bar content shifts when focusing on mousedown. r=jteow,desktop-theme-reviewers,urlbar-reviewers,dao

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e1d771b15d44