1906173 - [wpt-sync] Sync PR 46992 - [FedCM] Share more code between OnResolve and CompleteTokenRequest

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46992 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46992
Details from upstream follow.

Christian Biesinger <[e-mail]> wrote:

[FedCM] Share more code between OnResolve and CompleteTokenRequest

In particular, this makes us call SetRequiresUserMediation also for
OnResolve.

Bug: 349994201
Change-Id: I0d0f4d374e9ab601eb603d714930074923789218
Reviewed-on: https://chromium-review.googlesource.com/5673234
WPT-Export-Revision: 028acfe64237c9176b182051281ad2a088c7a691

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=147e9509274d1c5f05a58f7e5ba9edd52253068b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

TIMEOUT: 2

Chrome

TIMEOUT: 2

Safari

OK : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /credential-management/fedcm-authz/resolve-after-preventsilentaccess.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: OK)
  • Test that resolve clears the preventSilentAccess state.: TIMEOUT (Chrome: TIMEOUT, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /credential-management/fedcm-authz/resolve-after-preventsilentaccess.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d07f76600c8
[wpt PR 46992] - [FedCM] Share more code between OnResolve and CompleteTokenRequest, a=testonly

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/9d07f76600c8