1906185 - Enable Yelp suggestions by default in the Firefox Suggest section for the Suggest population

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Product wants to enable Yelp suggestions by default in the Firefox Suggest section (non-top-pick) in 129 for the Suggest population.

Comment 1

[Drew Willcoxon :adw]

This is the relevant branch config (non-top-pick) from the final Yelp v3 experiment:

{
  "yelpFeatureGate": true,
  "yelpSuggestPriority": false,
  "yelpShowLessFrequentlyCap": 3,
  "yelpMinKeywordLength": 4,
  "exposureResults": "rust_yelp",
  "showExposureResults": true
}

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1906185 - Enable Yelp suggestions by default in the Firefox Suggest section for the Suggest population.

This is the relevant branch config (non-top-pick) from the final Yelp v3 experiment
that we should now make the default:

{
  "yelpFeatureGate": true,
  "yelpSuggestPriority": false,
  "yelpShowLessFrequentlyCap": 3,
  "yelpMinKeywordLength": 4,
  "exposureResults": "rust_yelp",
  "showExposureResults": true
}

Ideally we might define minKeywordLength as part of the Yelp data in remote
settings and then modify the Rust component to ingest it as Yelp config data,
similar to weather suggestions. But that would require modifying the Rust
component, and Product wants Yelp for 129, so that means we would need to uplift
a vendoring of application-services to Beta, which I think we should avoid.

So instead I just set the default value of the minKeywordLength pref to 4. I
kept the Nimbus variable and it will override the pref if the pref still has its
default value. That way we can still use Nimbus to set it if there's some
emergency.

I also kept the yelpSuggestNonPriorityIndex and yelpSuggestPriority
variables, in case we need those too. Eventually we should clean up all the
variables and prefs we're not using anymore.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0c2ad1223d2
Enable Yelp suggestions by default in the Firefox Suggest section for the Suggest population. r=daisuke,urlbar-reviewers

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b0c2ad1223d2

Comment 5

[Drew Willcoxon :adw]

For verification, the Yelp keywords and modifiers are the same as they were for the final experiment, so you should be able to trigger Yelp suggestions the same as before. Below are some examples:

Subjects:

acai bowls
burgers
cafe
cooking classes
ramen

Pre-modifiers:

best
budget
cheap
good
local

Post-modifiers:

delivery

Locations:

near me
nearby
near by
in <city name>
near <city name>

Example queries:

ramen near me
burgers in chicago
cafe
cooking
pizza delivery