1906192 - Only enable trending suggestions on 128 for en-US / en-CA users

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Dale Harvey (:daleharvey)]

Starting 128, Recent Searches is default on for everyone, however the string Show trending search suggestions exposed in about:prefreces#search is not in the ln file: https://searchfox.org/mozilla-central/source/browser/components/urlbar/content/enUS-searchFeatures.ftl#351

The long term fix for this will be in https://bugzilla.mozilla.org/show_bug.cgi?id=1906103 however for 128 only we will only enable trending for en-US / en-CA users.

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1906192 - Only enable trending suggestions in 128 release for en-US users.

Comment 2

[Dale Harvey (:daleharvey)]

Comment on attachment 9411158 [details]
Bug 1906192 - Only enable trending suggestions in 128 release for en-US users.

Beta/Release Uplift Approval Request

• User impact if declined: Users will be shown untranslated strings in preferences
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Launch release with an en-US or en-CA build and see trending is enabled

Launch in other locales and see trending is disabled by default

• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Relatively small and sinple patch but has not had time to go though nightly testing process
• String changes made/needed: N/A
• Is Android affected?: No

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9411158 [details]
Bug 1906192 - Only enable trending suggestions in 128 release for en-US users.

Approved for 128.0rc2.

Comment 4

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/88cd912ac342

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr128/rev/88cd912ac342

Comment 6

[Adrian Florinescu [:aflorinescu]]

Verified as fixed with 128.0 (64-bit) RCbuild2 and 128.0ESR build2 on Windows 10 + Mac 11en-Us+en-CA locales - prefs enabled and en-GB and ro locales -prefs disabled.