1906291 - Land various tweaks in favor of a debugger tracer sidebar

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1906291 - [devtools] Rename console tracer class to resources.

This will better highlight that's a generic class used to communicate live trace to devtools fronts via JSTRACE_* resources.

Comment 2

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1906291 - [devtools] Pass source actor IDs instead of Debugger API Source.id.

We need that in order to have functional links for sources without URL (like evals).

Comment 3

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1906291 - [devtools] Align events array with trace.

This will help use the same indexes for all the shared attributes.

Comment 4

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1906291 - [devtools] Avoid mutation of the tracer frame array in the console.

The array may also be used by the debugger.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17873318ca4a
[devtools] Rename console tracer class to resources. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/d72f48618f38
[devtools] Pass source actor IDs instead of Debugger API Source.id. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/53b5ad4055ed
[devtools] Align events array with trace. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/6f0fa044aa35
[devtools] Avoid mutation of the tracer frame array in the console. r=devtools-reviewers,nchevobbe

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing talos perma failures @ jstracer/jstracer.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a24487e4777dea7d506061dedcf8f6443dd51123

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | damp | jstracer/jstracer.js: Test timed out

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42f1e1f1ceb7
[devtools] Rename console tracer class to resources. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/60495f694ac0
[devtools] Pass source actor IDs instead of Debugger API Source.id. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/cc75c837b71c
[devtools] Align events array with trace. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/7832bc78b5a7
[devtools] Avoid mutation of the tracer frame array in the console. r=devtools-reviewers,nchevobbe,perftest-reviewers,kshampur

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/42f1e1f1ceb7
https://hg.mozilla.org/mozilla-central/rev/60495f694ac0
https://hg.mozilla.org/mozilla-central/rev/cc75c837b71c
https://hg.mozilla.org/mozilla-central/rev/7832bc78b5a7