1906326 - Backup preferences UI appears on unrelated panes if they're loaded first

Status: RESOLVED FIXED

(Firefox :: Profile Backup, defect, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

Something about how we're initializing the backup-settings component makes the component visible, even if we're not on a pane that is supposed to show it, if that pane is the first to load.

STR:

1. Launch the browser with browser.backup.preferences.ui.enabled set to true
2. Visit about:preferences#sync

ER:

The backup preferences UI should not be displayed.

AR:

The backup preferences UI appears at the top of the Sync page, in this case.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1906326 - Don't manually unhide the dataBackupGroup in preferences if enabled. r?#preferences-reviewers!

The preferences initialization code will take care of showing and hiding
this for us when loading different panes - it's the data-hidden-from-search
attribute removal that's allowing us to show the group when the preference
is enabled.

The existing test_preferences_visibility test under
browser/components/backup/test/browser/browser_settings.js tests that we
haven't regressed showing and hiding behaviour for the pref.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42fb6fdf62d3
Don't manually unhide the dataBackupGroup in preferences if enabled. r=settings-reviewers,Gijs

Comment 3

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/42fb6fdf62d3