1906395 - Switch Servo to Gecko's alignment style representations

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Nico Burns]

Stylo currently contains source code for a separate (conditionally compiled) representation of the alignment styles ({align,justify}-{content,items,self}). This bug tracks removing that implementation in favour of Servo reusing Gecko's implementation.

This work is being upstreamed from https://github.com/servo/stylo/pull/47/commits

Comment 1

[Nico Burns]

Attachment: Bug 1906395 Remove adjust_for_alignment function (r=emilio)

This functionality should be implemented in layout, which it
now is.

Comment 2

[Nico Burns]

Attachment: Bug 1906395 - AlignFlags: Add flags method. Make value method public. (r=emilio)

A couple of tiny helper method to make accessing the AlignFlag values easier in Servo

Comment 3

[Nico Burns]

Attachment: Bug 1906395 - Switch Servo to use Gecko's alignment style implementations. (r=emilio)

Comment 4

[Nico Burns]

Attachment: Bug 1906395 - servo: unpreference alignment styles. r=emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16d315f26810
Remove adjust_for_alignment function (r=emilio)
https://hg.mozilla.org/integration/autoland/rev/d589c5cc511a
AlignFlags: Add flags method. Make value method public. (r=emilio)
https://hg.mozilla.org/integration/autoland/rev/a7f111e9f518
Switch Servo to use Gecko's alignment style implementations. (r=emilio)
https://hg.mozilla.org/integration/autoland/rev/427673ed0ce8
servo: unpreference alignment styles. r=emilio

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/16d315f26810
https://hg.mozilla.org/mozilla-central/rev/d589c5cc511a
https://hg.mozilla.org/mozilla-central/rev/a7f111e9f518
https://hg.mozilla.org/mozilla-central/rev/427673ed0ce8