1906405 - GetLast(Accessed|Modified)Time and *OfLinks are switched each other on Windows

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Masatoshi Kimura [:emk]]

Steps to reproduce:

1. Create a file on Windows Console: type nul > C:\ProgramData\foo
2. Create a symlink on Windows Console: mklink C:\ProgramData\bar C:\ProgramData\foo
3. Type following commands into Browser Console:

foo = FileUtils.File("C:\\ProgramData\\foo");
bar = FileUtils.File("C:\\ProgramData\\bar");
[bar.creationTime, bar.lastAccessedTime, bar.lastModifiedTime, bar.creationTimeOfLink, bar.lastAccessedTimeOfLink, bar.lastModifiedTimeOfLink]

Actual result (example):

Array(6) [ 1720162713196, 1720162758937, 1720162758937, 1720162758937, 1720162713196, 1720162713196 ]

Last accessed time and last modified time are swapped (creation time is ok). The link targets (the former three) can't be newer than the links themselves (the latter three).

Expected result (example):

Array(6) [ 1720162713196, 1720162713196, 1720162713196, 1720162758937, 1720162758937, 1720162758937 ]

If aFollowLinks parameter is true, GetDateImpl should get timestamps of link targets by following the links. If aFollowLinks is false, GetDateImpl should get timestamps of link themselves. But the current GetDateImpl is doing the opposite.

Comment 1

[Masatoshi Kimura [:emk]]

I found another defect of the patch in bug 1786608. Commented on D155926.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:beth, since you are the author of the regressor, bug 1786608, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Bug 1906405 - Fix nsLocalFile::GetLast(Accessed|Modified)Time. r?#xpcom-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d40105caed00
Fix nsLocalFile::GetLast(Accessed|Modified)Time. r=xpcom-reviewers,emilio

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for causing xpcshell failures on test_localfile.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=d40105caed0076cf4ea7321ecbb1c90e52f8b524&selectedTaskRun=OEsG2C1cR32OxO6Yb530-w.0

Failure logs:

• xpcshell test_localfile.js https://treeherder.mozilla.org/logviewer?job_id=465322123&repo=autoland
• bc browser_thumbnails_bg_captureIfMissing.js https://treeherder.mozilla.org/logviewer?job_id=465322066&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/c20ff88ba49173d08135b500bb0dd9b4e4993258

Comment 6

[Masatoshi Kimura [:emk]]

Yet another bug of the regressor.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/012d30f6eae4
Fix nsLocalFile::GetLast(Accessed|Modified)Time. r=xpcom-reviewers,emilio

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/012d30f6eae4

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Is there a user-facing impact from this bug that would make us want to consider uplifting the fix?

Comment 10

[Masatoshi Kimura [:emk]]

No. This is very edge-case scenario.