1906496 - Error: no selectedSource

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[liltechdude]

Error:
Error: no selectedSource

React Component Stack:
in Connect(EmptyLines)
in div
in div
in Editor
in Connect(Editor)
in div
in main
in div
in div
in SplitBox
in div
in div
in SplitBox
in AppErrorBoundary
in div
in App
in Connect(App)
in Provider
in Provider

Stacktrace:
mapStateToProps@resource://devtools/client/debugger/src/components/Editor/EmptyLines.js:98:11
mapToPropsProxy@resource://devtools/client/shared/vendor/react-redux.js:1776:92
detectFactoryAndVerify@resource://devtools/client/shared/vendor/react-redux.js:1785:24
mapToPropsProxy@resource://devtools/client/shared/vendor/react-redux.js:1776:46
handleFirstCall@resource://devtools/client/shared/vendor/react-redux.js:1911:18
pureFinalPropsSelector@resource://devtools/client/shared/vendor/react-redux.js:1959:81
runComponentSelector@resource://devtools/client/shared/vendor/react-redux.js:1233:39
initSelector@resource://devtools/client/shared/vendor/react-redux.js:1385:23
Connect@resource://devtools/client/shared/vendor/react-redux.js:1326:15
constructClassInstance@resource://devtools/client/shared/vendor/react-dom.js:8270:18
updateClassComponent@resource://devtools/client/shared/vendor/react-dom.js:10592:27
beginWork@resource://devtools/client/shared/vendor/react-dom.js:11419:16
performUnitOfWork@resource://devtools/client/shared/vendor/react-dom.js:14702:12
workLoop@resource://devtools/client/shared/vendor/react-dom.js:14720:24
renderRoot@resource://devtools/client/shared/vendor/react-dom.js:14803:15
performWorkOnRoot@resource://devtools/client/shared/vendor/react-dom.js:15655:17
performWork@resource://devtools/client/shared/vendor/react-dom.js:15567:24
performSyncWork@resource://devtools/client/shared/vendor/react-dom.js:15541:14
requestWork@resource://devtools/client/shared/vendor/react-dom.js:15410:5
scheduleWork@resource://devtools/client/shared/vendor/react-dom.js:15224:16
enqueueSetState@resource://devtools/client/shared/vendor/react-dom.js:8192:17
Component.prototype.setState@resource://devtools/client/shared/vendor/react.js:328:16
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1412:16
dispatch@resource://devtools/client/shared/vendor/redux.js:265:7
waitUntilService/</<@resource://devtools/client/debugger/src/actions/utils/middleware/wait-service.js:71:24
promiseMiddleware/</<@resource://devtools/client/debugger/src/actions/utils/middleware/promise.js:38:14
context/</<@resource://devtools/client/debugger/src/actions/utils/middleware/context.js:84:12
thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:100
dispatch@resource://devtools/client/shared/vendor/redux.js:681:28
selectLocation/<@resource://devtools/client/debugger/src/actions/sources/select.js:269:13

Comment 1

[Julian Descottes [:jdescottes]]

Thanks for the report, we probably should not throw in mapStateToProps here, and just return empty props.
Although this might go away with CodeMirror6 (Bug 1773246).

Quick question: do you reproduce this issue regularly? If yes, can you share steps to reproduce? Thanks

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1906496 - [devtools] Avoid throwing from debugger components when there is no selected source.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bb77f99b1a3
[devtools] Avoid throwing from debugger components when there is no selected source. r=devtools-reviewers,bomsy

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8bb77f99b1a3