1906540 - Remove mozrunner devices and mozdevice from SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: General, task)

Description

[Ian Neal]

We don't need mozrunner devices or mozdevice in the SeaMonkey tree so remove that code.

Comment 1

[Ian Neal]

Attachment: TOP-1906540-mozrunner-devices-removal-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Ian Neal]

Attachment: TOP-1906540-mozdevice-removal-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 3

[Ian Neal]

Attachment: TOP-1906540-mozdevice-removal-comm-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: check.patch

I found a few more references and als removed part of Bug 787203. Suspect it will not not work without additinalremovals. Could you check and add to the other patches what you think can be used.

Comment 5

[Ian Neal]

Attachment: TOP-1906540-mozdevice-removal-mozilla-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Note: def check_output is used by other parts of jittests.py so kept it

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9411434 [details] [diff] [review]
TOP-1906540-mozdevice-removal-comm-25320.patch

lgtm r/a+ for our 2.53 branch

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9411445 [details] [diff] [review]
TOP-1906540-mozdevice-removal-mozilla-25320.patch

lgtm r/a+ for our 2.53 branch

Comment 8

[Frank-Rainer Grahl (:frg)]

Fixed in our 2.53 branches only.

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/a49337c37218cc46fb2e8f49a1cea1b5f4a10e3a
Remove mozrunner devices and mozdevice from SeaMonkey - mozdevice part in comm. r=frg a=frg

https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/c8e5b204f280543aa0b34944d44c9102bc14d79d
Remove mozrunner devices and mozdevice from SeaMonkey. r=frg a=frg