1906587 - Preview tooltip doesn't work on expression `this[x].y`

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the console
2. Evaluate the following expression

new(class {
  constructor() {
    this.x = {
      y: 42
    };
    const prop = "x";
    this[prop].y;
    debugger;
  }
});

3. Once the debugger is opened, hover y in the this[prop].y line

Expected results

The preview tooltip is displayed, with the expected value, 42

Actual results

The preview tooltip isn't displayed.
In stdout, I can see the following error: Preview for <this.[name].value> threw a SyntaxError

Notice the . before [name], which explains the syntax error

Comment 1

[Julian Descottes [:jdescottes]]

Let's at least add a test here to make sure this gets fixed when migrating to codemirror.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1906587 - [devtools] Fix preview for this property access with bracket notation. r=#devtools-reviewers.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7ab50577b53
[devtools] Fix preview for this property access with bracket notation. r=devtools-reviewers,ochameau.

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e7ab50577b53