1906622 - Unable to navigate using keyboard navigation after reaching the "Manage Nightly settings" link from the Customize Sidebar

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: 2024-07-08_14h09_13.mp4

Found in

• Nightly 129.0a1

Affected versions

• Nightly 129.0a1 (2024-07-08)

Affected platforms

• All

Preconditions

• Set the following prefs:
  sidebar.revamp - true
  sidebar.verticalTabs - true

Steps to reproduce

1. Open the Customize Sidebar panel.
2. Use Tab in order to reach the Manage Nightly settings link.
3. Use Tab or Shift tab in order to move away from the link.

Expected result

• The user should be able to navigate without issues.

Actual result

• The user can reach the Manage Nightly settings link but remains locked on the link unable to move away from it.

Regression range
Not a regression.

Comment 1

[Anna Yeddi [:ayeddi]]

This is an access-S3 issue that makes parts of the UI, especially the navigation to the web content, difficult for users of assistive technologies to use.

While the current implementation is not fully blocking most of a11y customers from using the feature, it is a high access-S3 because it does create barriers for many groups of users, especially those keyboard-only users who are new to relying on the keyboard input only, for users of switch devices and other alternative inputs.

This keyboard trap can be exited by using an F6 key to move between Firefox landmarks, but it is not something that is expected to happen (it is a workaround) and some less experienced users or users with cognitive disabilities may not be aware of. Users may also not know if there is anything in the list after this link. But this trap, in fact, happens with the very last element of the sidebar, so I'm triaging it as access-S3 which is very close to the bug 1905305 and the access-S2 realm.

Comment 3

[Stuart Colville [:muffinresearch]]

Attachment: Bug 1906622 - Move preventDefault call to avoid keyboard trap r=#sidebar-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37077f49fed7
Move preventDefault call to avoid keyboard trap r=sidebar-reviewers,nsharpley

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/37077f49fed7

Comment 6

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 130.0a1 (2024-08-04)