Closed Bug 1906644 Opened 2 years ago Closed 1 year ago

DecodeQ in nsMIMEHeaderParamImpl.cpp doesn't check the return value of PR_sscanf

Categories

(Core :: Networking, defect, P2)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
139 Branch
Tracking Flags:
Tracking Status
firefox139 --- fixed

People

(Reporter: mccr8, Assigned: thampan)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [necko-triaged][necko-priority-next])

Attachments

(1 file, 1 obsolete file)

Bug 1906644 - Fix unchecked return value. r=#necko
48 bytes, text/x-phabricator-request
Details | Review

here. See bug 265693.

If the return value can be ignored, it could be changed to something like Unused << to indicate that it is intentional.

Severity: -- → S4
Keywords: good-first-bug
Priority: -- → P2
Whiteboard: [necko-triaged][necko-priority-next]
Assignee: nobody → jishnu.mt
Attachment #9477856 - Flags: approval-mozilla-beta?
Attachment #9477856 - Flags: approval-mozilla-beta?

jishnu.mt, i think you meant to base this revision for central and not beta. I'm removing the beta nomination flag that automatically gets set and changing the Phab revision to mozilla-central. Please let me know if i am mistaken.

Flags: needinfo?(jishnu.mt)

diannaS, you are right, sorry for the confusion. I will fix that

Flags: needinfo?(jishnu.mt)
Attachment #9477856 - Attachment is obsolete: true
Pushed by smayya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd6eee818c6c Fix unchecked return value. r=necko-reviewers,jesup

https://hg.mozilla.org/mozilla-central/rev/bd6eee818c6c

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox139: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch
QA Whiteboard: [qa-triage-done-c140/b139]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: