1906650 - Chapter 1: implement Trusted Types support for `Element.insertAdjacentHTML` without default-policy support without reporting violations

Status: RESOLVED FIXED

(Core :: DOM: Security, task)

Description

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

https://html.spec.whatwg.org/#dom-parsing-and-serialization:dom-element-insertadjacenthtml

Relevant test: https://searchfox.org/mozilla-central/rev/6936c4c3fc9bee166912fce10104fbe0417d77d3/testing/web-platform/tests/trusted-types/block-string-assignment-to-Element-insertAdjacentHTML.html#27.

Here, TrustedHTML is used as a non-variadic argument. That's simpler than https://bugzilla.mozilla.org/show_bug.cgi?id=1906301.

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1906650: part 1) Make `TrustedHTML` and analogous classes cycle-collected. r=peterv

Union types in WebIDL for variadic arguments require this
(https://firefox-source-docs.mozilla.org/dom/webIdlBindings/index.html#union-types).

If this results in an efficiency problem, one might try to change union
types to allow non-reference-counted members. For now, this was agreed
with peterv.

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1906650: part 3) Add `TrustedHTML` to `Element.insertAdjacentHTML`. r=smaug,peterv

Depends on D216169

Comment 3

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1906650: part 2) Add `nsCSPPolicy::AreTrustedTypesForSinkGroupRequired`. r=tschuster

To be used in a following part.

If nsCSPDirective::AreTrustedTypesForSinkGroupRequired turns out to be
to ineffcient, release builds could simply return mDirective == REQUIRE_TRUSTED_TYPES_FOR_DIRECTIVE since there's currently only one
sink group ("script"). nsCSPParser adds the directive for
REQUIRE_TRUSTED_TYPES_FOR_DIRECTIVE only if that sink group is parsed
too.

Depends on D216169

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a63bba70fa30
part 1) Make `TrustedHTML` and analogous classes cycle-collected. r=peterv

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a63bba70fa30

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

It would be nice to not land individual patches from a bug. There is a risk that one patch ends up to one release and some other patch to another and if there are then issues with the patch, backing out stuff gets a bit messy.

Comment 7

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

(In reply to Olli Pettay [:smaug][[e-mail]] from comment #6)

It would be nice to not land individual patches from a bug. There is a risk that one patch ends up to one release and some other patch to another and if there are then issues with the patch, backing out stuff gets a bit messy.

Agreed. The disadvantage of keeping patches unlanded is that they may bit-rot. I'll try to respect the soft-code-freezes (https://whattrainisitnow.com/calendar/) and move the remaining patches to a separate ticket if the affected releases differ.

Comment 8

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

(In reply to Mirko Brodesser (:mbrodesser-Igalia) from comment #7)

(In reply to Olli Pettay [:smaug][[e-mail]] from comment #6)

It would be nice to not land individual patches from a bug. There is a risk that one patch ends up to one release and some other patch to another and if there are then issues with the patch, backing out stuff gets a bit messy.

Agreed. The disadvantage of keeping patches unlanded is that they may bit-rot. I'll try to respect the soft-code-freezes (https://whattrainisitnow.com/calendar/) and move the remaining patches to a separate ticket if the affected releases differ.

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1909878 for Lando to check that.

Comment 9

[Phabricator Automation]

Comment on attachment 9412281 [details]
Bug 1906650: part 2) Add nsCSPPolicy::AreTrustedTypesForSinkGroupRequired. r=tschuster

Revision D216304 was moved to bug 1913077. Setting attachment 9412281 [details] to obsolete.

Comment 10

[Phabricator Automation]

Comment on attachment 9412042 [details]
Bug 1906650: part 3) Add TrustedHTML to Element.insertAdjacentHTML. r=smaug,peterv

Revision D216170 was moved to bug 1913077. Setting attachment 9412042 [details] to obsolete.