1906720 - Use same interface to convert YUV data w/ or w/out alpha to BGR* buffer

Status: RESOLVED FIXED

(Core :: Graphics, task, P1)

Description

[C.M.Chang[:chunmin]]

Since PlanarAlphaData is included in PlanarYCbCrData, ConvertYCbCrAToARGB(const layers::PlanarYCbCrData& aYCbCr, const layers::PlanarAlphaData& aAlpha, ... ) can be reduced to ConvertYCbCrAToARGB(const layers::PlanarYCbCrData& aYCbCr, ...) and it makes sense to have a general API to convert the given YUV data into a BGRA buffer.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1906720 - Simplify to-8-bit-color YUV data conversion

Depends on D215159

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1906720 - Move YUV-to-RGB scaling conversion into a helper

Depends on D215952

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1906720 - Move YUV-to-RGB conversion into a helper

Depends on D215953

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1906720 - Introduce ConvertYCbCrToRGB32 for unified YUV to BGRA/BGRX conversion

Depends on D215954

Comment 5

[C.M.Chang[:chunmin]]

Attachment: Bug 1906720 - Embed ConvertYCbCrToRGBInternal into ConvertYCbCrToRGB

Depends on D215956

Comment 6

[C.M.Chang[:chunmin]]

Attachment: Bug 1906720 - Replace ConvertYCbCrAToARGB with ConvertYCbCrToRGB32 in nsAVIFDecoder

Currently, ConvertYCbCrAToARGB is only used in nsAVIFDecoder and the
usage doesn't scale the image, so ConvertYCbCrAToARGB can be replaced
with the ConvertYCbCrToRGB32 introduced in the previous patch.

Depends on D215956

Comment 7

[C.M.Chang[:chunmin]]

Attachment: Bug 1906720 - Simplify nsAVIFDecoder by using ConvertYCbCrToRGB32 exclusively

This patch simplifies the code path in nsAVIFDecoder. Previously,
nsAVIFDecoder relied on both ConvertYCbCrToRGB and
ConvertYCbCrToRGB32 to convert YUV data to BGRX or BGRA, depending on
the presence of an alpha channel. With recent changes, nsAVIFDecoder
can now use ConvertYCbCrToRGB32 exclusively to streamline the
conversion process.

Depends on D215985

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f96ec16bcec
Simplify to-8-bit-color YUV data conversion r=gfx-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/3050cc69ee08
Move YUV-to-RGB scaling conversion into a helper r=gfx-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/a98ee51e1b1f
Move YUV-to-RGB conversion into a helper r=gfx-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/0bccf07f3774
Introduce ConvertYCbCrToRGB32 for unified YUV to BGRA/BGRX conversion r=gfx-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/90cdcc49bcbd
Replace ConvertYCbCrAToARGB with ConvertYCbCrToRGB32 in nsAVIFDecoder r=gfx-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/745b3e3d9636
Simplify nsAVIFDecoder by using ConvertYCbCrToRGB32 exclusively r=gfx-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/20f587028f0e
Embed ConvertYCbCrToRGBInternal into ConvertYCbCrToRGB r=gfx-reviewers,nical

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8f96ec16bcec
https://hg.mozilla.org/mozilla-central/rev/3050cc69ee08
https://hg.mozilla.org/mozilla-central/rev/a98ee51e1b1f
https://hg.mozilla.org/mozilla-central/rev/0bccf07f3774
https://hg.mozilla.org/mozilla-central/rev/90cdcc49bcbd
https://hg.mozilla.org/mozilla-central/rev/745b3e3d9636
https://hg.mozilla.org/mozilla-central/rev/20f587028f0e