Closed Bug 1906853 Opened 1 year ago Closed 1 year ago

add glean probe for http3 udp datagram size

Categories

(Core :: Networking, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
firefox132 --- fixed

People

(Reporter: mail, Assigned: mail)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0

As part of this Bug I would like to add two Glean metrics:

  • http3_udp_datagram_size_send
  • http3_udp_datagram_size_received

This will enable us to measure the impact of:

This commit adds two Glean probes:

  • http3_udp_datagram_size_send
  • http3_udp_datagram_size_received

This will enable us to measure the impact of:

Severity: -- → N/A
Priority: -- → P2
Whiteboard: [necko-triaged]
Assignee: nobody → mail
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9411763 - Attachment description: WIP: Bug 1906853 - add glean probe for http3 udp datagram size → Bug 1906853 - add glean probe for http3 udp datagram size
Attachment #9411763 - Attachment description: Bug 1906853 - add glean probe for http3 udp datagram size → Bug 1906853 - add glean probe for http3 udp datagram size r=acreskey
Attachment #9411763 - Attachment description: Bug 1906853 - add glean probe for http3 udp datagram size r=acreskey → WIP: Bug 1906853 - add glean probe for http3 udp datagram size
Depends on: 1915388

Jan-Erik can you give another estimate for Bugzilla#1915388?

In case Bugzilla#1915388 can be used sometime this week, I suggest blocking here as discussed out-of-band. No need to introduce an intermediary solution.

Otherwise I would like to put the thread-local metric buffer proposed in phabricator#D216034 up for review. See netwerk/socket/neqo_glue/src/metrics.rs in phabricator#D216034.

In my eyes the thread-local metric buffer is a good intermediary solution until Bugzilla#1915388 is ready. It will enable us to measure the impact of bugzilla#1901295 (currently in Nightly) and bugzilla#1909910. Before promoting either of these two patches to beta, we can replace the intermediary thread-local metric buffer solution with Bugzilla#1915388.

What do you think?

Flags: needinfo?(jrediger)

I'm waiting for bug 1914241 and related to land (hopefully today), after that I can do the rest of the work for Glean. So my estimate is still by end of this week.
As said in our meeting I do'nt want to block you further, so if you want to go with your buffer for the time being I'm happy to do the work to switch it out once the Glean solution landed though.

Flags: needinfo?(jrediger)
Attachment #9411763 - Attachment description: WIP: Bug 1906853 - add glean probe for http3 udp datagram size → Bug 1906853 - add glean probe for http3 udp datagram size r=janerik,jesup,kershaw
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/16d3f3129704 add glean probe for http3 udp datagram size r=necko-reviewers,kershaw,janerik
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: