1906901 - Alignment tests are failing because of missing line-height property

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect, P2)

Description

[Tiaan Louw [:tlouw]]

As recommended by wpt, the Ahem font should be used with a specified line-height.

https://web-platform-tests.org/writing-tests/ahem.html

Comment 1

[Tiaan Louw [:tlouw]]

Attachment: Bug 1906901 - Add missing line-height property to grid alignment tests. r=#layout

The line-height property is recommended to be set for tests using the
Ahem font:

https://web-platform-tests.org/writing-tests/ahem.html

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/babc084013f1
Add missing line-height property to grid alignment tests. r=layout-reviewers,emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47223 for changes under testing/web-platform/tests

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing WR failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/52c8d3c9e76883306ce280ef34fb0723a694a248

Push with failures

Failure log ->

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ab8b2ade384
Add missing line-height property to grid alignment tests. r=layout-reviewers,emilio

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8ab8b2ade384

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot