1906931 - Update start-shell.bat to not use MinTTY when invoked from inside Windows Terminal

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task, P3)

Description

[Alex Hochheiden [:ahochheiden]]

Instead of instructing users to manually add "USE_MINTTY": "0" to a Windows Terminal profile, we could set it to 0 if we detect we're invoked from within Windows Terminal.

Proof of concept code snippet:

powershell -Command "if ($env:WT_SESSION) { exit 0 } else { exit 1 }"
if %errorlevel% equ 0 (
    echo Running in Windows Terminal
) else (
    echo Not running in Windows Terminal
)

Just need to adjust it to be within the IF NOT DEFINED USE_MINTTY block (so that we don't override a user preference, if set).

Comment 1

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1906931 - Update start-shell.bat to not use MinTTY when invoked from inside Windows Terminal r?#build

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-build/rev/55f42a7a2755
Update start-shell.bat to not use MinTTY when invoked from inside Windows Terminal r=firefox-build-system-reviewers,glandium