Closed
Bug 1906988
Opened 1 year ago
Closed 28 days ago
[toolbar redesign] improve navbar feature flags
Categories
(Firefox for Android :: Toolbar, enhancement, P3)
Tracking
()
RESOLVED
INVALID
People
(Reporter: mavduevskiy, Assigned: mavduevskiy)
References
Details
Attachments
(1 obsolete file)
The shouldAddNavigationBar/navigationToolbarEnabled pair was causing quite a bit of confusion through last months of work on the navbar. Also, extension functions are not straightforward to mock. This is an attempt to make the code more readable, following a conversation with :petru
|
Assignee | |
Updated•1 year ago
|
Assignee: nobody → mavduevskiy
|
|
Assignee | |
Comment 1•1 year ago
|
||
Refactor extention function Context.shouldAddNavigationBar into Settings.navigationToolbarVisible. Hopefully, it will improve readability and will help to distinguish it from the navigationToolbarEnabled feature flag.
|
||
Updated•1 year ago
|
Severity: -- → N/A
Priority: -- → P3
|
||
Updated•7 months ago
|
Attachment #9411923 -
Attachment is obsolete: true
|
||
Updated•28 days ago
|
Status: NEW → RESOLVED
Closed: 28 days ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•