1907043 - Unable to launch browser from firefox.exe -p (without specify profile name) due to Crash in [@ mozilla::BounceTrackingProtection::GetSingleton::$::operator()]

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Alice0775 White]

Attachment: screenshot from crash reporter

Steps to reproduce:

1. Download autoland build (changeset 52e546f18388)
   https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/RMojitXbSn6Uy9ABuGifgg/runs/0/artifacts/public/build/target.zip
2. Exstract zip
3. Run firefox.exe -p without specify profile name
4. Profile chooser dialog will popup as expected
5. Choose a profile
6. Click on Start Nightly button

Actual results:
Crash reporter dialog appears. The Browser would not start.

Expected results:
Start browser normally.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7c0a7798caa8014d9c983f099e402b55ab570be3&tochange=52e546f1838854c4e46d226c06a19a411c9ccb5d

Note:
It works as expected if specify a profile name e.g, firefox.exe -p test

Interestingly ,
A. If the profile chooser dialog is displayed and the Enter key is pressed without doing anything, the browser starts without any problem.
B. If the profile chooser dialog is displayed and click on Start Nightly button without doing anything, the browser crashes.
C. If you select a profile other than the pre-selected profile in the profile chooser dialog and then press the Enter key, the browser crashes.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:pbz, since you are the author of the regressor, bug 1844563, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Alice0775 White]

same issue on ububtu22.04.
bp-83b0f244-5efa-4d8c-83a7-714550240710

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1844563

Comment 4

[Alice0775 White]

Crash report: https://crash-stats.mozilla.org/report/index/207ce30e-0bc8-40c8-847d-ac6c50240710

Reason: SIGSEGV / SEGV_MAPERR

Top 10 frames:

0  libxul.so  mozilla::BounceTrackingProtection::GetSingleton()::$_0::operator()() const  toolkit/components/antitracking/bouncetrackingprotection/BounceTrackingProtection.cpp:108
0  libxul.so  std::_Function_handler<void (), mozilla::BounceTrackingProtection::GetSinglet...  /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/8/bits/std_function.h:297
1  libxul.so  mozilla::KillClearOnShutdown(mozilla::ShutdownPhase)  xpcom/base/ClearOnShutdown.cpp:55
1  libxul.so  mozilla::AppShutdown::AdvanceShutdownPhaseInternal(mozilla::ShutdownPhase, bo...  xpcom/base/AppShutdown.cpp:416
2  libxul.so  mozilla::AppShutdown::AdvanceShutdownPhase(mozilla::ShutdownPhase, char16_t c...  xpcom/base/AppShutdown.cpp:456
2  libxul.so  mozilla::ShutdownXPCOM(nsIServiceManager*)  xpcom/build/XPCOMInit.cpp:665
3  libxul.so  NS_ShutdownXPCOM  xpcom/build/XPCOMInit.cpp:580
3  libxul.so  ScopedXPCOMStartup::~ScopedXPCOMStartup()  toolkit/xre/nsAppRunner.cpp:1960
4  libxul.so  ShowProfileManager(nsIToolkitProfileService*, nsINativeAppSupport*)  toolkit/xre/nsAppRunner.cpp:2860
5  libxul.so  XREMain::XRE_mainStartup(bool*)  toolkit/xre/nsAppRunner.cpp:4891

Comment 5

[Paul Zühlcke [:pbz]]

Thanks! I’ll take a look.

Comment 6

[Paul Zühlcke [:pbz]]

Attachment: Bug 1907043 - Add null checks for BTP shutdown cleanup. r=#anti-tracking!

Comment 7

[Paul Zühlcke [:pbz]]

Should be fixed by backout: https://bugzilla.mozilla.org/show_bug.cgi?id=1844563#c5

Comment 8

[Phabricator Automation]

Comment on attachment 9412213 [details]
Bug 1907043 - Add null checks for BTP shutdown cleanup. r=#anti-tracking!

Revision D216261 was moved to bug 1844563. Setting attachment 9412213 [details] to obsolete.

Comment 9

[Ina Popescu, Desktop QA]

I've replicated this issue on Windows10 x64 following the STR from Comment 0.
Verified as fixed in the latest Firefox 131.0b1 version on Windows10 x64, macOS11, and Ubuntu22.04, as the issue no longer occurs.