1907259 - Breakpoint aren't working properly when wrap line option is enabled

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: misplaced breakpoint preview on hover

If you enable the wrap line option and shrink the editor so it's very narrow, the breakpoint preview on hover is misplaced.
Also, you can trigger a block collapse when clicking on the gutter, even if you didn't click on the button itself

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

This helps with the styling:

diff --git a/devtools/client/debugger/src/components/Editor/Breakpoints.css b/devtools/client/debugger/src/components/Editor/Breakpoints.css
--- a/devtools/client/debugger/src/components/Editor/Breakpoints.css
+++ b/devtools/client/debugger/src/components/Editor/Breakpoints.css
@@ -40,7 +40,7 @@
 .cm-lineNumbers .cm-gutterElement:not(.empty-line, .cm6-gutter-breakpoint):hover {
   background: url(chrome://devtools/content/debugger/images/breakpoint.svg) no-repeat;
   background-size: auto 15px;
-  background-position: right;
+  background-position: top right;
   -moz-context-properties: fill, stroke;
   fill: var(--gutter-hover-background-color);
   stroke: var(--gutter-hover-background-color);

But it seems that enabling the wrapping also messes up with the line gutter even listener, as clicking on the line does not trigger https://searchfox.org/mozilla-central/rev/01aaa47e62a2015e7641f26ab0bc2bb00ab579b8/devtools/client/debugger/src/components/Editor/index.js#243-244

editor.setGutterEventListeners({
  click: (event, cm, line) => {

Comment 2

[Hubert Boma Manilla (:bomsy)]

But it seems that enabling the wrapping also messes up with the line gutter even listener, as clicking on the line does not trigger https://searchfox.org/mozilla-central/rev/01aaa47e62a2015e7641f26ab0bc2bb00ab579b8/devtools/client/debugger/src/components/Editor/index.js#243-244

editor.setGutterEventListeners({
  click: (event, cm, line) => {

This is fixed by the patch in Bug 1907260

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1907259 - [devtools] Fix the hover breakpoint styling when line wrapping is on r=#devtools-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c957d178a74d
[devtools] Fix the hover breakpoint styling when line wrapping is on r=devtools-reviewers,nchevobbe

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c957d178a74d