Closed Bug 1907278 Opened 1 year ago Closed 1 year ago

Better shutdown handling in PlacesFrecencyRecalculator.sys.mjs

Categories

(Toolkit :: Places, task)

Product:
Toolkit
Component:
Places
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

Bug 1907278 - Shutdown PlacesFrecencyRecalculator earlier and don't handle topics after finalization. r=daisuke
48 bytes, text/x-phabricator-request
Details | Review

This is not the cause of Bug 1905548, but while looking at the code I noticed that calling #finalize() is not effectively stopping us from handling nsIObserver topics. We can probably also anticipate finalization SHUTDOWN_PHASE_APPSHUTDOWNCONFIRMED as this is not critical to run at any shutdown phase.

Component: DOM: Service Workers → Places
Product: Core → Toolkit
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/77cd74699118 Shutdown PlacesFrecencyRecalculator earlier and don't handle topics after finalization. r=daisuke,places-reviewers

https://hg.mozilla.org/mozilla-central/rev/77cd74699118

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: